Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-59695

"Lock" and "Lock after" settings are not mutually exclusive

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Not a bug
    • Affects Version/s: 3.3.1
    • Fix Version/s: None
    • Component/s: Gradebook
    • Labels:
    • Testing Instructions:
      Hide

      Case 1

      • Select "Grader Report" from Grade Administration
      • Click "Turn Editing On"
      • Click on any Settings Gear Icon
      • Click on Checkbox for Enable for Lock after.
      • Observe that the Locked checkbox is disabled to gray so that user can't check Locked when Locked after is enabled.

      Case 2

      • Select "Gradebook Setup" from Grade Administration
      • Click "Add Grade Item"
      • If you don't see Locked after, click on Show more..
      • Click on Checkbox for Enable for Lock after.
      • Observe that the Locked checkbox is disabled to gray so that user can't check Locked when Locked after is enabled.

      Case 3

      • Select "Gradebook Setup" from Grade Administration
      • Click "Edit"(Edit Settings) next to Grade Category
      • If you don't see Locked after, click on Show more..
      • Click on Checkbox for Enable for Lock after.
      • Observe that the Locked checkbox is disabled to gray so that user can't check Locked when Locked after is enabled.
      Show
      Case 1 Select "Grader Report" from Grade Administration Click "Turn Editing On" Click on any Settings Gear Icon Click on Checkbox for Enable for Lock after. Observe that the Locked checkbox is disabled to gray so that user can't check Locked when Locked after is enabled. Case 2 Select "Gradebook Setup" from Grade Administration Click "Add Grade Item" If you don't see Locked after, click on Show more.. Click on Checkbox for Enable for Lock after. Observe that the Locked checkbox is disabled to gray so that user can't check Locked when Locked after is enabled. Case 3 Select "Gradebook Setup" from Grade Administration Click "Edit"(Edit Settings) next to Grade Category If you don't see Locked after, click on Show more.. Click on Checkbox for Enable for Lock after. Observe that the Locked checkbox is disabled to gray so that user can't check Locked when Locked after is enabled.
    • Affected Branches:
      MOODLE_33_STABLE
    • Pull Master Branch:
      MDL-59695_lock_and_lock_until_mutually_exclusive

      Description

      The "Lock" and "Lock after" settings should be mutually exclusive. In the code there is a disableif statement that will disable the Hidden setting if Hidden until is enabled. But it is not working and not correctly setup.

      This patch will resolve that.

        Attachments

          Issue Links

            Activity

              People

              Assignee:
              rex Rex Lorenzo
              Reporter:
              rex Rex Lorenzo
              Peer reviewer:
              Mark Nelson
              Participants:
              Component watchers:
              Adrian Greeve, Jake Dallimore, Mathew May, Mihail Geshoski, Peter Dias
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved: