[MDL-59701] MariaDB 10.2.7 breaks ddl unit tests - Moodle Tracker

XML

Word

Printable

Affected Branches:
MOODLE_32_STABLE, MOODLE_33_STABLE
Epic Link:
MySQL-8.0
Testing Instructions:
Hide

Install Moodle on MariaDB 10.2.7 (Hint - use Docker)

Confirm the PHPUnit test suite passes.

Regression tests, do the same with:

MariaDB 10.2.6 or below (CI does this)

MySQL 5.7 (CI does this)
Show
Install Moodle on MariaDB 10.2.7 (Hint - use Docker) Confirm the PHPUnit test suite passes. Regression tests, do the same with: MariaDB 10.2.6 or below (CI does this) MySQL 5.7 (CI does this)

markn@markn ~/htdocs/i32mysql $ vendor/bin/phpunit lib/ddl/tests/ddl_test.php

Moodle 3.2.4+ (Build: 20170727), 6702f7a90790e9836c30c54e636ba52f88fd3941

Php: 7.1.7.1.16.04.1.1, mariadb: 10.2.7, OS: Linux 4.4.0-87-generic x86_64

PHPUnit 5.5.7 by Sebastian Bergmann and contributors.

........E..........................                               35 / 35 (100%)

Time: 4.51 seconds, Memory: 40.00MB

There was 1 error:

1) core_ddl_testcase::test_change_field_type

ddl_change_structure_exception: DDL sql execution error (Truncated incorrect INTEGER value: '4.0000000000'

ALTER TABLE phpu_test_table_cust0 MODIFY COLUMN anothernumber BIGINT(10) NOT NULL DEFAULT 10)

/home/markn/mstorage/i32mysql/moodle/lib/dml/moodle_database.php:485

/home/markn/mstorage/i32mysql/moodle/lib/dml/mysqli_native_moodle_database.php:1015

/home/markn/mstorage/i32mysql/moodle/lib/ddl/database_manager.php:77

/home/markn/mstorage/i32mysql/moodle/lib/ddl/database_manager.php:595

/home/markn/mstorage/i32mysql/moodle/lib/ddl/tests/ddl_test.php:1101

/home/markn/mstorage/i32mysql/moodle/lib/phpunit/classes/database_driver_testcase.php:143

To re-run:

 vendor/bin/phpunit core_ddl_testcase lib/ddl/tests/ddl_test.php

ERRORS!

Tests: 35, Assertions: 350, Errors: 1.

Discovered while testing

MDL-59583 MariaDB 10.2.7 breaks dml unit tests

duplicates

MDL-59596 Unit test failure with MariaDB/MySQL8