Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-59736

Display discussionlocked string as notification

    XMLWordPrintable

Details

    • Improvement
    • Resolution: Fixed
    • Minor
    • 3.4
    • 3.3.1
    • Forum
    • MOODLE_33_STABLE
    • MOODLE_34_STABLE
    • wip-MDL-59736-master
    • Hide
      1. Open some forum where you have old discussions
      2. Set lockdiscussionsafter to something small
      3. Create a course
      4. Create a forum activity in the course
      5. Create a discussion in the forum
      6. View the forum table in your database (called mdl_forum if you're using mdk)
      7. Update the lockdiscussionafter column and set it to 1 instead of 0 (this will lock the discussion 1 second after it's created).
      8. View discussion as a student and make sure the warning about discussion being locked is displayed in a notification box
      Show
      Open some forum where you have old discussions Set lockdiscussionsafter to something small Create a course Create a forum activity in the course Create a discussion in the forum View the forum table in your database (called mdl_forum if you're using mdk) Update the lockdiscussionafter column and set it to 1 instead of 0 (this will lock the discussion 1 second after it's created). View discussion as a student and make sure the warning about discussion being locked is displayed in a notification box

    Description

      Very easy to miss the "This discussion is locked" string on the forum page because it has no styling.
      Example: https://moodle.org/mod/forum/discuss.php?d=251783

      Why not use standard notification for it?

      (see MDL-55982)

      Attachments

        1. lockeddiscussion.png
          51 kB
          Marina Glancy
        2. lockeddiscussionafter.png
          53 kB
          Marina Glancy

        Issue Links

          Activity

            People

              marina Marina Glancy
              marina Marina Glancy
              Jun Pataleta Jun Pataleta
              Eloy Lafuente (stronk7) Eloy Lafuente (stronk7)
              Ryan Wyllie Ryan Wyllie
              Votes:
              1 Vote for this issue
              Watchers:
              5 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Clockify

                  Error rendering 'clockify-timesheets-time-tracking-reports:timer-sidebar'. Please contact your Jira administrators.