Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-59738

Create add_filereference_from_(file|string) and make add_file_to_pool protected

    XMLWordPrintable

    Details

    • Type: Improvement
    • Status: Open
    • Priority: Minor
    • Resolution: Unresolved
    • Affects Version/s: 3.4
    • Fix Version/s: None
    • Component/s: Files API
    • Labels:
      None
    • Affected Branches:
      MOODLE_34_STABLE

      Description

      As it says on the tin, the add_file_to_pool and add_stirng_to_pool functions should never have been public.

      We should introduce a new function to solve the one usage in the repository where this is abused and rid ourselves of this nastiness.

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                Unassigned
                Reporter:
                dobedobedoh Andrew Nicols
                Participants:
                Component watchers:
                Matteo Scaramuccia, Jake Dallimore, Jun Pataleta, Ryan Wyllie
              • Votes:
                1 Vote for this issue
                Watchers:
                3 Start watching this issue

                Dates

                • Created:
                  Updated: