Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-59759

Remove the Confirm AMD modal type

    XMLWordPrintable

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 3.4
    • Fix Version/s: 3.4
    • Component/s: JavaScript, Usability
    • Labels:
    • Testing Instructions:
      Hide
      Course participants
      1. Login as a teacher to a course.
      2. Go to the course participants page.
      3. Click the trash icon on one of the students.
      4. Check the unernol modal.
        • Confirm that the buttons show "Unenrol" and "Cancel".
      5. Click on "Unenrol"
        • Confirm that the selected student gets unenrolled.
      Calendar
      1. Go to the calendar page and create a user event.
      2. Click on the user event to open the event modal.
      3. Click "Delete"
      4. Check the event deletion confirmation modal.
        • Confirm that the buttons show "Delete event" and "Cancel".
      5. Click on "Delete event"
        • Confirm that the event gets deleted.
      Messaging
      1. Log in as a student s1 and send one or more messages to another student s2.
      2. Log in as s2 and check your messages from s1.
      3. Click on "Edit" at the top right corner of the messaging window.
      4. Click on "Delete all"
      5. Check the message deletion confirmation modal.
        • Confirm that the buttons show "Delete" and "Cancel".
      6. Click on "Delete"
        • Confirm that all of the messages are deleted.
      Behat
      1. Initialise Behat to run on all themes: 

        php admin/tool/behat/cli/init.php -a

        (For a faster run time, use -j=n, where n is the number of parallel runs.)

      1. Run the following Behat test and confirm that everything passes: 

        php admin/tool/behat/cli/run.php --tags="@core_user,@core_calendar,@message"

       Backwards-compatibility test
      1. Undo the commit https://github.com/junpataleta/moodle/commit/fb7fa04e3b173e12fd152435472f3ef5a915d0df
      2. Go to the calendar page and create a user event.
      3. Click on the user event to open the event modal.
      4. Click "Delete"
      5. Check the event deletion confirmation modal. The buttons will show "Save changes" and "Cancel".
      6. Click on "Save changes"
        • Confirm that the event gets deleted.
      Show
      Course participants Login as a teacher to a course. Go to the course participants page. Click the trash icon on one of the students. Check the unernol modal. Confirm that the buttons show "Unenrol" and "Cancel". Click on "Unenrol" Confirm that the selected student gets unenrolled. Calendar Go to the calendar page and create a user event. Click on the user event to open the event modal. Click "Delete" Check the event deletion confirmation modal. Confirm that the buttons show "Delete event" and "Cancel". Click on "Delete event" Confirm that the event gets deleted. Messaging Log in as a student s1 and send one or more messages to another student s2. Log in as s2 and check your messages from s1. Click on " Edit " at the top right corner of the messaging window. Click on " Delete all " Check the message deletion confirmation modal. Confirm that the buttons show "Delete" and "Cancel". Click on "Delete" Confirm that all of the messages are deleted. Behat Initialise Behat to run on all themes: php admin/tool/behat/cli/init.php -a (For a faster run time, use -j= n , where n is the number of parallel runs.) Run the following Behat test and confirm that everything passes: php admin/tool/behat/cli/run.php --tags="@core_user,@core_calendar,@message"  Backwards-compatibility test Undo the commit https://github.com/junpataleta/moodle/commit/fb7fa04e3b173e12fd152435472f3ef5a915d0df Go to the calendar page and create a user event. Click on the user event to open the event modal. Click "Delete" Check the event deletion confirmation modal. The buttons will show "Save changes" and "Cancel". Click on "Save changes" Confirm that the event gets deleted.
    • Affected Branches:
      MOODLE_34_STABLE
    • Fixed Branches:
      MOODLE_34_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-59759-master-2
    • Pull Master Diff URL:

      Description

      Yes/No dialogs are a no-no as it hinders usability. We need to remove it in order to discourage its use. 

      The way to go is to use the Save/Cancel type of AMD modal instead, in which has a customisable save button text.

        Attachments

          Issue Links

          Discovered while testing

          Bug - A problem which impairs or prevents Moodle from functioning correctly. MDL-59757 Delete icon makes a Yes/No dialog.

          • Minor - Minor loss of function where workaround is possible
          • Closed
          has to be done after

          Task - A task that needs to be completed. Tasks usually refer to work that must be done outside the product. MDL-60013 Final deprecation for core/modal_confirm

          • Minor - Minor loss of function where workaround is possible
          • Closed
          will help resolve

          Improvement - An enhancement to an existing Moodle feature. MDL-59937 Confirm delete modal should use "delete" and "cancel"

          • Minor - Minor loss of function where workaround is possible
          • Closed

            Activity

              People

              Assignee:
              jpataleta Jun Pataleta
              Reporter:
              jpataleta Jun Pataleta
              Peer reviewer:
              Andrew Lyons Andrew Lyons
              Integrator:
              David Monllaó David Monllaó
              Tester:
              Ryan Wyllie Ryan Wyllie
              Participants:
              Component watchers:
              Andrew Lyons, Dongsheng Cai, Huong Nguyen, Jun Pataleta, Michael Hawkins, Shamim Rezaie, Simey Lameze, Barbara Ramiro, Bas Brands
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Fix Release Date:
                13/Nov/17