Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-59800

theme_bootstrapbase mapping of BS4 .card class is incorrect

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 3.3.1
    • Fix Version/s: 3.4
    • Component/s: HTML and CSS, Themes
    • Labels:

      Description

      https://github.com/moodle/moodle/blob/master/theme/bootstrapbase/less/moodle/bs4-compat.less#L7

      // Add support for card. We map it to well.
      // This is not meant to be perfect - but at least applies some styles to a bs4 card.
      .card:extend(.well) {
      }
      

      This is incorrect, card should have white background. Class .card-header should have gray background (similar to .well)

        Attachments

        1. afterpatch.png
          afterpatch.png
          32 kB
        2. calendarcard_boost.png
          calendarcard_boost.png
          28 kB
        3. calendarcard_clean.png
          calendarcard_clean.png
          34 kB
        4. clean-boost-event-display.png
          clean-boost-event-display.png
          212 kB

          Issue Links

            Activity

              People

              Assignee:
              marina Marina Glancy
              Reporter:
              marina Marina Glancy
              Peer reviewer:
              Ryan Wyllie
              Integrator:
              Andrew Nicols
              Tester:
              David Monllaó
              Participants:
              Component watchers:
              Amy Groshek, David Scotson, Amaia Anabitarte, Carlos Escobedo, Ferran Recio, Sara Arjona (@sarjona), Víctor Déniz Falcón, Bas Brands
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Fix Release Date:
                13/Nov/17