Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-59800

theme_bootstrapbase mapping of BS4 .card class is incorrect

    XMLWordPrintable

Details

    Description

      https://github.com/moodle/moodle/blob/master/theme/bootstrapbase/less/moodle/bs4-compat.less#L7

      // Add support for card. We map it to well.
      // This is not meant to be perfect - but at least applies some styles to a bs4 card.
      .card:extend(.well) {
      }
      

      This is incorrect, card should have white background. Class .card-header should have gray background (similar to .well)

      Attachments

        1. calendarcard_boost.png
          calendarcard_boost.png
          28 kB
        2. calendarcard_clean.png
          calendarcard_clean.png
          34 kB
        3. afterpatch.png
          afterpatch.png
          32 kB
        4. clean-boost-event-display.png
          clean-boost-event-display.png
          212 kB

        Issue Links

          Activity

            People

              marina Marina Glancy
              marina Marina Glancy
              Ryan Wyllie Ryan Wyllie
              Andrew Lyons Andrew Lyons
              David Monllaó David Monllaó
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:
                13/Nov/17