-
Bug
-
Resolution: Unresolved
-
Minor
-
None
-
3.3, 3.4, Future Dev
-
MOODLE_33_STABLE, MOODLE_34_STABLE
-
MDL-59853-master
-
- Go to "OAuth 2 services" admin page.
- Add a fake custom issuer that does not provide discovery, but has a favicon.ico in its root. For instance:
- Click "Create new custom service".
- Fill in required data: Name, Client ID, Client Secret (you may be creative, they all don't matter).
- As a Service base URL, fill in https://moodle.org/
- Click "Save changes".
- Verify that the output looks like the following screenshot. You need to see two notifications (one success, one warning) and the issuer in the table, together with its favicon.
Expected output:
Go to "OAuth 2 services" admin page. Add a fake custom issuer that does not provide discovery, but has a favicon.ico in its root. For instance: Click "Create new custom service". Fill in required data: Name, Client ID, Client Secret (you may be creative, they all don't matter). As a Service base URL , fill in https://moodle.org/ Click "Save changes". Verify that the output looks like the following screenshot. You need to see two notifications (one success, one warning) and the issuer in the table, together with its favicon. Expected output:
When creating/updating OAuth 2 issuers in admin/tool/oauth2/issuers.php, Moodle tries autoconfigurations for
a) service endpoints (discover_endpoints())
b) favicon (guess_image())
If discover_endpoints() fails for any reason (e.g. service does not provide discovery information), it throws an exception that is caught too late, so that a) no icon is set and b) the user is presented with an error "error/Could not discover end points for identity issuernextCloud" (and yes, the space between "issuer" and the issuer name is missing 
). The issuer is created regardless.
EXPECTED
Try all autoconfiguration steps, no matter if one of them fails. Show a warning if one of them fails for any reason. Also, show a success message if an issuer was created.
- will help resolve
-
CONTRIB-6950 Plugin approval: ownCloud (repository_owncloud)
-
- Closed
-