Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-59864

Add link to activity in summary modal for activity events

XMLWordPrintable

    • Icon: Improvement Improvement
    • Resolution: Fixed
    • Icon: Minor Minor
    • 3.4
    • 3.4
    • Calendar
    • MOODLE_34_STABLE
    • MOODLE_34_STABLE
    • MDL-59864-master
    • Hide
      1. Log in as admin and go to a course.
      2. Create an choice module, setting available dates.
      3. Log in as a participant of the course (student or teacher is fine)
      4. Go to the calendar.
      5. Click on the event that was automatically created (choice open).
      6. Make sure there is a Go to activity link.
      7. Click on that link and make sure you are redirected to the choice module page.
      Show
      Log in as admin and go to a course. Create an choice module, setting available dates. Log in as a participant of the course (student or teacher is fine) Go to the calendar. Click on the event that was automatically created (choice open). Make sure there is a Go to activity link. Click on that link and make sure you are redirected to the choice module page.

      As part of MDL-59393 I had to stop activity events from being editable (because they shouldn't be) but that also means that the edit button that was perviously linking to the module is no longer shown.

      I think it might make more sense to actually show a link in the footer that says something like "go to activity" instead of an edit button anyway since it it clearer for the user.

      Also, please remember to add this behat scenario back:

        @javascript
      		 
        Scenario: Module events editing
      		 
          Given I log in as "admin"
      		 
          And I am on "Course 1" course homepage with editing mode on
      		 
          And the following "activities" exist:
      		 
            | activity | course | idnumber | name          | intro                   | timeopen      | timeclose     |
      		 
            | choice   | C1     | choice1  | Test choice 1 | Test choice description | ##yesterday## | ##tomorrow##  |
      		 
          When I follow "This month"
      		 
          Then I should see "Choice Test choice 1 open"
      		 
          And I should see "Choice Test choice 1 close"
      		 
          When I click on "Choice Test choice 1 open" "link"
      		 
          Then "Delete" "button" should not exist
      		 
          And I should see "Open event"
      		 
          And "Edit" "button" should exist
      		 
          When I click on "Edit" "button"
      		 
          And I wait to be redirected
      		 
          Then I should see "Updating: Choice"
      		 
          And I am on "Course 1" course homepage
      		 
          And I follow "This month"
      		 
          When I click on "Choice Test choice 1 close" "link"
      		 
          Then "Delete" "button" should not exist
      		 
          And I should see "Close event"
      		 
          And "Edit" "button" should exist
      		 
          When I click on "Edit" "button"
      		 
          And I wait to be redirected
      		 
          Then I should see "Updating: Choice"

      Might be necessary to adjust this to click on the new link and not on the edit button

        1. activity link.png
          activity link.png
          19 kB

            lameze Simey Lameze
            ryanwyllie Ryan Wyllie
            Ryan Wyllie Ryan Wyllie
            David Monllaó David Monllaó
            John Okely John Okely
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

              Created:
              Updated:
              Resolved:

                Error rendering 'clockify-timesheets-time-tracking-reports:timer-sidebar'. Please contact your Jira administrators.