Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-59867

autocomplete ajax can put results in wrong form element

    XMLWordPrintable

    Details

    • Testing Instructions:
      Hide

      On master:

      As admin go to the participants page for a course.

      Click the enrol users button to open the enrol users popup.

      Verify there is no visual glitch after the second auto-complete element (see screenshot).

      Close the popup.

      Repeat this test at least 10 times (more if you are generous).

       

      On stables - test the tags element on a module settings form looks and works the same before/after this patch. In this case I don't think it's worth a big effort to make a fake test on stables. It's highly dependent on the time to render the thing (I couldn't reproduce it with the tags element for example).

       

      Show
      On master: As admin go to the participants page for a course. Click the enrol users button to open the enrol users popup. Verify there is no visual glitch after the second auto-complete element (see screenshot). Close the popup. Repeat this test at least 10 times (more if you are generous).   On stables - test the tags element on a module settings form looks and works the same before/after this patch. In this case I don't think it's worth a big effort to make a fake test on stables. It's highly dependent on the time to render the thing (I couldn't reproduce it with the tags element for example).  
    • Affected Branches:
      MOODLE_34_STABLE
    • Fixed Branches:
      MOODLE_32_STABLE, MOODLE_33_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-59867-master

      Description

      In the new participants page there are 2 auto complete fields in the enrolment popup. By opening and closing this popup, it is possible to get the form in a state where the ajax handlers are bound to the wrong form elements. There is also a visual glitch that occurs when this happens (makes it easier to reproduce) - there is a subtle gray line under the cohort selector.

       

        Attachments

          Issue Links

            Activity

              People

              Assignee:
              damyon Damyon Wiese
              Reporter:
              damyon Damyon Wiese
              Peer reviewer:
              Jake Dallimore
              Integrator:
              David Monllaó
              Tester:
              David Mudrák (@mudrd8mz)
              Participants:
              Component watchers:
              Adrian Greeve, Jake Dallimore, Mathew May, Mihail Geshoski, Peter Dias
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Fix Release Date:
                13/Nov/17