-
Bug
-
Resolution: Fixed
-
Minor
-
3.2.4, 3.3.1, 3.4
-
MOODLE_32_STABLE, MOODLE_33_STABLE, MOODLE_34_STABLE
-
MOODLE_32_STABLE, MOODLE_33_STABLE
-
wip-
MDL-59881-master -
-
3.4 Sprint 4
question_usage_by_activity::start_all_questions has three parameters, but only uses the first one in the function.
The restore_stepslib_date_test is periodically failing, because when it starts a new quiz attempt the timestamp is not utilized.
Time: 13.9 minutes, Memory: 334.00MB
|
There was 1 failure:
|
1) restore_stepslib_date_testcase::test_question_attempt_steps_date_restore
|
Failed asserting that '1503042635' matches expected 1503042636.
|
/home/travis/build/snake/moodle/backup/moodle2/tests/restore_stepslib_date_test.php:410
|
/home/travis/build/snake/moodle/lib/phpunit/classes/advanced_testcase.php:80
|
|
This can be tested by adding a sleep(1) between the lines $attempt = quiz_create_attempt(... }} and {{quiz_start_new_attempt around line 360.
To me this looks like an oversight as $qa->start takes a timestamp but is just not supplied the parameter. The same goes for userid (though this is not causing a unit test failure).
- is a regression caused by
-
MDL-59518 Restore date should not roll for user created data - Core components
-
- Closed
-