Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-59882

Replace ' in the ".modal-body" "css_element"' with something sensible.

    XMLWordPrintable

    Details

    • Testing Instructions:
      Hide

      These changes only affect behat, never-the-less the following tests should be executed manually by a tester as some of the steps are currently only used without JavaScript:

      1. Edit my/tests/behat/restrict_available_blocks.feature
      2. Find the "Remove the ability to add the comments block to Dashboard" Scenario
      3. Add the @javascript tag
      4. Run the test in boost
        1. Confirm that it passes
      Show
      These changes only affect behat, never-the-less the following tests should be executed manually by a tester as some of the steps are currently only used without JavaScript: Edit my/tests/behat/restrict_available_blocks.feature Find the " Remove the ability to add the comments block to Dashboard " Scenario Add the @javascript tag Run the test in boost Confirm that it passes
    • Affected Branches:
      MOODLE_32_STABLE, MOODLE_33_STABLE, MOODLE_34_STABLE
    • Fixed Branches:
      MOODLE_32_STABLE, MOODLE_33_STABLE
    • Pull Master Branch:
      MDL-59882-master

      Description

      We're beginning to litter the place with things like this:

      +    And "C1" "link" should exist in the ".modal-body" "css_element"
      

      How about we make a new step definition to replace ".modal-body" "css_element" with something like "modal" "element" which translates to the CSS so that themes can override this?

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                dobedobedoh Andrew Nicols
                Reporter:
                dobedobedoh Andrew Nicols
                Peer reviewer:
                Jun Pataleta
                Integrator:
                Eloy Lafuente (stronk7)
                Tester:
                Ankit Agarwal
                Participants:
                Component watchers:
                Andrew Nicols, Mathew May, Michael Hawkins, Shamim Rezaie, Simey Lameze, Amaia Anabitarte, Bas Brands, Carlos Escobedo, Sara Arjona (@sarjona), Víctor Déniz Falcón
              • Votes:
                0 Vote for this issue
                Watchers:
                2 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  13/Nov/17