Assign: assorted bug fixes for the download submissions feature

Test prereqs:

1. 3 students and 1 teacher enrolled in a course.
2. 2 groups:
   • Group A containing student 1
   • Group B containing student 2
   • Student 3 is NOT in a group.
3. 1 Grouping, containing both Group A and B.
4. 5 image files on your local fs for testing uploads.
5. An assignment (A1) with:
   • Online text submissions enabled
   • GroupMode set to 'separate groups'
   • Feedback files = true
   • Student submit in groups = yes, and set grouping to the grouping you created.
6. An assignment (A2) with:
   • Online text submissions enabled
   • GroupMode set to 'separate groups'
   • Feedback files = true
   • Students submit in groups = no

Test onlinetext file links work after downloading

For assignment 1:

1. As student 1, create a submission and upload image 1 and image 4 in the online text area. Submit this.
2. As student 2, create a submission and upload image 2 and image 5 in the online text area. Submit this.
3. As student 3, create a submission and upload image 3 in the online text area. Submit this.
4. As the teacher, on the view all submission page, make sure the checkbox 'Download submissions in folders' is ticked (bottom of page).
5. Make sure the separate groups select is set to 'All participants'
6. Select 'Download all submissions' from the grading action select.
7. Confirm that the filename does not contain any double hyphens (--), nor does it contain the group name.
8. Extract the resulting zip file and confirm that:
   • You see a folder for each student submission
   • Each student is prefixed with 'Group A', 'Group B' or 'Default group' respectively. Student 3 is listed as 'Default group' because they are not in the grouping - this is normal.
   • Inside each student submission folder you see the 2 corresponding image files and an 'onlinetext.html' file.
   • The image file names are not prefixed with anything.
9. Open the onlinetext.html file for each student and confirm the images are displayed (i.e. confirm the link works).
10. Now, uncheck the checkbox 'Download submissions in folders'
11. Select 'Download all submissions' from the grading action select
12. Extract the resulting zip file and confirm that:
    • All submission files are prefixed with 'Group A', 'Group B' or 'Default group' respectively.

For assignment 2:

1. Repeat the above download steps with 'Download submissions in folders' enabled. Extract the file. This time confirm that:
   • No group prefix is present on the student folder nor on the submission files.
2. Open the onlinetext.html file for each student and confirm the images are displayed (i.e. confirm the link works).
3. Repeat the above download steps with 'Download submissions in folders' disabled. Extract the file. This time confirm that:
   • No group prefix is present on any of the the submission files.
4. Open the onlinetext.html file for each student and confirm the images are displayed (i.e. confirm the link works).

Feedback files regression test (uploading multiple feedback files in a zip)

1. For each of the assignments:
   • Set downloadasfolders = true (ticked)
   • Download all submissions with 'all participants' selected and extract files
   • Edit the onlinetext.html for one student and save changes.
   • Select all student submission folders and create a zip
   • Select 'Upload multiple feedback files in a zip' from the 'Grading action' select
   • Pick your newly created zip file and upload
   • Confirm that you see the feedback files for all students and that you can see the modified text for the student submission you modified.
   • Repeat above steps with 'downloadasfolders' set to false (unticked).
   • Repeat above steps but instead of selecting 'all participants', select a specific group.