Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-59945

Incompatible signature in sync_users() method between LDAP and DB auth plugins

    XMLWordPrintable

    Details

    • Type: Improvement
    • Status: Reopened
    • Priority: Major
    • Resolution: Unresolved
    • Affects Version/s: 3.3.1, 3.4
    • Fix Version/s: None
    • Component/s: Authentication
    • Labels:

      Description

      In LDAP auth plugin:

      auth_plugin_ldap::sync_users($do_updates=true)

       

      In DB auth plugin:

      auth_plugin_db::sync_users(progress_trace $trace, $do_updates=false)

       

      (the problem is inherited by other plugins, e.g. CAS, which extends one of that)

       

      This situation limit refactoring possibilities, such as:

      • it requires a specific scheduled task for each plugin instead of a generic one
      • it prevents the  pull up of sync_users() as abstract method or parent method in the auth_plugin_base class
      • it forces if/then clauses in external plugins which use the codebase of LDAP o DB one

       

        Attachments

          Issue Links

            Activity

              People

              Assignee:
              Unassigned
              Reporter:
              aulaweb AulaWeb Università di Genova
              Peer reviewer:
              Mark Nelson
              Participants:
              Component watchers:
              Adrian Greeve, Jake Dallimore, Mathew May, Mihail Geshoski, Peter Dias
              Votes:
              0 Vote for this issue
              Watchers:
              6 Start watching this issue

                Dates

                Created:
                Updated: