[MDL-59954] Using Drag & Drop to upload files in a course does not ignore size limit for teachers - Moodle Tracker

XML

Word

Printable

Details

Type: Bug
Status: Closed
Priority: Minor
Resolution: Fixed
Affects Version/s: 3.3.1, 3.7
Fix Version/s: 3.5.4, 3.6.2
Component/s: Course, Files API, Resource
Labels:
- ci
- release_notes
- triaged

Testing Instructions:
Hide

Prerequisites:

Confirm moodle/course:ignorefilesizelimits is enabled for the teacher

Testing Instructions:

Login as a teacher

Goto a course and edit the settings

Set Maximum limit to 10kb

Navigate back to the course page

Turn editing on

Drag and drop a file > 10kb onto the page

Select either of the options and upload

Confirm no file size restriction error message pops up and file appears on course page
Show
Prerequisites: Confirm moodle/course:ignorefilesizelimits is enabled for the teacher Testing Instructions: Login as a teacher Goto a course and edit the settings Set Maximum limit to 10kb Navigate back to the course page Turn editing on Drag and drop a file > 10kb onto the page Select either of the options and upload Confirm no file size restriction error message pops up and file appears on course page
Affected Branches:
MOODLE_33_STABLE, MOODLE_37_STABLE
Fixed Branches:
MOODLE_35_STABLE, MOODLE_36_STABLE
Pull from Repository:
git://github.com/peterRd/moodle.git
Pull 3.5 Branch:
~~MDL-59954~~-35
Pull 3.5 Diff URL:
https://github.com/peterRd/moodle/compare/2fbae51df0...MDL-59954-35
Pull 3.6 Branch:
~~MDL-59954~~-36
Pull 3.6 Diff URL:
https://github.com/peterRd/moodle/compare/11d0c68d56...MDL-59954-36
Pull Master Branch:
~~MDL-59954~~-master
Pull Master Diff URL:
https://github.com/peterRd/moodle/compare/33a388eff7...MDL-59954-master

Description

The upload limit for files set in course settings normally does not apply to teachers of that course.

Reproduce:

1) Go to a course in which you at least have teacher role
2) Go to course settings and set the maximum upload size to a limit.
3) Add a new file resource, the upload file dialog still shows you that file size is unlimited, since you are a teacher
4) Go back to the course, turn on edit mode, and try to directly add a file via drag & drop on the course -> you will get an error: "The file is too large and cannot be uploaded"

Attachments

Options
- Sort By Name
- Sort By Date
- Ascending
- Descending
- Thumbnails
- List
- Download All

Attachments

MDL-59954.PNG
151 kB
20/Dec/18 9:02 AM

Activity

People

Assignee:

Peter Dias

Reporter:

Stefan Weber

Peer reviewer:

Mihail Geshoski

Integrator:

Adrian Greeve

Tester:

Anna Carissa Sadia

Participants:

Adrian Greeve, Andrew Nicols, Anna Carissa Sadia, CiBoT, Mihail Geshoski, Peter Dias, Stefan Weber

Component watchers:

Amaia Anabitarte, Bas Brands, Carlos Escobedo, Sara Arjona (@sarjona), Víctor Déniz Falcón, Matteo Scaramuccia, Jake Dallimore, Jun Pataleta, Ryan Wyllie, Adrian Greeve, Mihail Geshoski, Peter Dias

Votes:

5 Vote for this issue

Watchers:

9 Start watching this issue

Dates

Created:

28/Aug/17 11:24 PM

Updated:

07/May/19 1:51 PM

Resolved:

20/Dec/18 10:10 PM

Fix Release Date:

14/Jan/19

Time Tracking

Estimated:

Remaining:

Logged:

20m