Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-59963

Report > Logs pages miss origin parameter upon pagination

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 3.2.4, 3.3.1
    • Fix Version/s: 3.2.5, 3.3.2
    • Component/s: Reports
    • Labels:
    • Testing Instructions:
      Hide
      • Open a course log page under Report > Logs, that's something like https://qa.moodle.net/report/log/index.php?id=2.
      • Select an origin, e.g. change "All sources" to "Web".
      • Press the "Get these logs" button.
      • The results appear.
      • If the results have more than one page (we hope so!), skip to the next one by using the pagination.
      • The next page is shown with just the results with the previously selected origin and the selection in the pulldown selector preserved.
      Show
      Open a course log page under Report > Logs, that's something like https://qa.moodle.net/report/log/index.php?id=2 . Select an origin, e.g. change "All sources" to "Web". Press the "Get these logs" button. The results appear. If the results have more than one page (we hope so!), skip to the next one by using the pagination. The next page is shown with just the results with the previously selected origin and the selection in the pulldown selector preserved.
    • Affected Branches:
      MOODLE_32_STABLE, MOODLE_33_STABLE
    • Fixed Branches:
      MOODLE_32_STABLE, MOODLE_33_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-59963-report-logs-origin-pagination

      Description

      Upon showing the logs report having a origin filter (e.g. "Web" or "Webservice") when you paginate, the filter is not kept but misses and jumps to default "All sources".

      To reproduce

      • Open a course log page under Report > Logs, that's something like https://qa.moodle.net/report/log/index.php?id=2.
      • Select an origin, e.g. change "All sources" to "Web".
      • Press the "Get these logs" button.
      • The results appear.
      • If the results have more than one page (we hope so!), skip to the next one by using the pagination.

      What you expect

      • The next page is shown, honoring the "Web" origin choice.

      What actually happens

      • A next page is shown, but regardlessly of the origin choice. The selection skips back to "All sources" and no origin parameter exists in the URL.

        Attachments

          Activity

            People

            • Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:
                Fix Release Date:
                11/Sep/17