Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-60008

File won't render in the grader if both submission types are selected

    XMLWordPrintable

    Details

    • Testing Instructions:
      Hide
      1. Make sure your site has a working ghost script (Site administration / Plugins / Assignment plugins / Feedback plugins / Annotate PDF / Test ghostscript path), but no document converters enabled.
      2. Create an assignment with "Online text" and "File submissions" enabled in the "Submission types" section. Make sure 2 files can be submitted.
      3. Login as a student and submit a PDF file as the assignment submission with no online text.
      4. Login as a teacher and grade the submission. The PDF should appear in the grading interface and should only contain the submitted PDF so the teacher can draw / annotate it.
      5. Login as the student and edit the submission so that it now has online text as well as a PDF.
      6. Login as a teacher and grade the submission. The PDF should appear in the grading interface and should contain the online text and the submitted PDF so the teacher can draw / annotate it.
      7. Enable the uno conv document converter (make sure it is working)
      8. Login as the student and edit the submission. Add an MP3 file to the submission.
      9. Login as a teacher and grade the submission. The PDF should appear in the grading interface so the teacher can draw / annotate it, but there should be a warning at the bottom of the PDF panel that indicates that there are some files can only be downloaded (The message will disappear after a while)
      10. Draw a line on the PDF and verify a message is displayed at the bottom of the PDF panel that says "Draft annotations saved". (The message will disappear after a while)

      Test all the following steps in "Boost" theme and "Clean" theme.

      1. Resize the window so it is narrow and verify the layout of the grading screen changes so that the panels are now displayed one after the other and the edit pdf panel is collapsible
      2. Open a menu (comment colour) from the edit PDF toolbar and verify the width of the menu does not rest of the browser window
      3. Open the search comments dialogue and verify the button to expand / collapse the review panel does not show through the background of the dialogue
      4. Resize the window so it is wider (at least 1000px) and verify the 3 buttons to change the layout of the panels are now visible at the bottom right corner.
      5. Verify the buttons to change the layout of the panels are not excessively tall (they should match the height of the "Save changes" button)

       

      Show
      Make sure your site has a working ghost script (Site administration / Plugins / Assignment plugins / Feedback plugins / Annotate PDF / Test ghostscript path), but no document converters enabled. Create an assignment with "Online text" and "File submissions" enabled in the "Submission types" section. Make sure 2 files can be submitted. Login as a student and submit a PDF file as the assignment submission with no online text. Login as a teacher and grade the submission. The PDF should appear in the grading interface and should only contain the submitted PDF so the teacher can draw / annotate it. Login as the student and edit the submission so that it now has online text as well as a PDF. Login as a teacher and grade the submission. The PDF should appear in the grading interface and should contain the online text and the submitted PDF so the teacher can draw / annotate it. Enable the uno conv document converter (make sure it is working) Login as the student and edit the submission. Add an MP3 file to the submission. Login as a teacher and grade the submission. The PDF should appear in the grading interface so the teacher can draw / annotate it, but there should be a warning at the bottom of the PDF panel that indicates that there are some files can only be downloaded (The message will disappear after a while) Draw a line on the PDF and verify a message is displayed at the bottom of the PDF panel that says "Draft annotations saved". (The message will disappear after a while) Test all the following steps in "Boost" theme and "Clean" theme. Resize the window so it is narrow and verify the layout of the grading screen changes so that the panels are now displayed one after the other and the edit pdf panel is collapsible Open a menu (comment colour) from the edit PDF toolbar and verify the width of the menu does not rest of the browser window Open the search comments dialogue and verify the button to expand / collapse the review panel does not show through the background of the dialogue Resize the window so it is wider (at least 1000px) and verify the 3 buttons to change the layout of the panels are now visible at the bottom right corner. Verify the buttons to change the layout of the panels are not excessively tall (they should match the height of the "Save changes" button)  
    • Affected Branches:
      MOODLE_33_STABLE, MOODLE_35_STABLE
    • Fixed Branches:
      MOODLE_37_STABLE
    • Pull from Repository:
    • Pull 3.5 Branch:
    • Pull 3.6 Branch:
    • Pull Master Branch:
      MDL-60008-master

      Description

      When grading an assignment submission that has been configured to accept both a file submission and an online text submission, the file fails to render and appears blank. I would expect that the submitted file would render. Note that any online text submitted does appear as expected. Steps to reproduce:

      • As a Teacher in a course, create an Assignment
      • Within the Submission types section, make sure both Online text and File submissions are checked
      • As a Student, submit a file to the Assignment (whether you also enter text or not in the Online text field is irrelevant)
      • As a Teacher, grade the submissions; any submitted file should fail to render

      This is, admittedly, mostly an edge case. I suspect that most Assignments are configured to allow either file or online text submissions (with most, I imagine, accepting files by default), and rarely both. I caught this only by chance when a new faculty unfamiliar with Moodle accidentally checked both. I can, however, imagine certain use cases where an instructor might want to have both available, such as, e.g., if the submitted file is an Excel document or perhaps a PowerPoint (which will still render), and in addition the user needs to include some explanatory text or whatever within the Online text field.

        Attachments

        1. 1.PNG
          1.PNG
          136 kB
        2. 2.PNG
          2.PNG
          211 kB
        3. 2017-09-11_14-22-09.png
          2017-09-11_14-22-09.png
          165 kB
        4. 3.PNG
          3.PNG
          175 kB
        5. first-time-loading.png
          first-time-loading.png
          119 kB

          Issue Links

            Activity

              People

              • Votes:
                18 Vote for this issue
                Watchers:
                25 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  20/May/19

                  Time Tracking

                  Estimated:
                  Original Estimate - 0 minutes
                  0m
                  Remaining:
                  Remaining Estimate - 0 minutes
                  0m
                  Logged:
                  Time Spent - 1 hour
                  1h