[MDL-60012] Regression in formslib: "neq" condition no longer working on radio buttons. - Moodle Tracker

XML

Word

Printable

Affected Branches:
MOODLE_34_STABLE
Fixed Branches:
MOODLE_34_STABLE
Pull from Repository:
git://github.com/davosmith/moodle.git
Pull Master Branch:
~~MDL-60012~~_form_neq_regression
Pull Master Diff URL:
https://github.com/davosmith/moodle/compare/moodle:master...MDL-60012_form_neq_regression
Testing Instructions:
Hide

Place the attached 'formneqtestpage.php' script in the root directory of your test site

Visit [site]/formneqtestpage.php

Click on the radio buttons

Ensure that the text fields are disabled as expected when you select the different radio buttons

Note that the fact that neither textbox is disabled when neither radio button is selected is outside the scope of this ticket - possibly 'neq' should activate when no radio button is selected, but this patch fixes the behaviour back to how it was before the regression.
Show
Place the attached 'formneqtestpage.php' script in the root directory of your test site Visit [site] /formneqtestpage.php Click on the radio buttons Ensure that the text fields are disabled as expected when you select the different radio buttons Note that the fact that neither textbox is disabled when neither radio button is selected is outside the scope of this ticket - possibly 'neq' should activate when no radio button is selected, but this patch fixes the behaviour back to how it was before the regression.

Noticed in the attendance plugin when running behat on master - not an issue on stable versions - seems to be a regression caused by ~~MDL-53848~~

the condition "neq" on radio button selector doesn't seem to work anymore.

$mform->disabledIf('groups', 'sessiontype', 'neq', mod_attendance_structure::SESSION_GROUP);

The "groups" selector is always disabled no matter what the radio button "sessiontype" is set to.

replacing it with an "eq" instead of a "neq" seems to work better:

$mform->disabledIf('groups', 'sessiontype', 'eq', mod_attendance_structure::SESSION_GROUP);

here's the example in the Attendance code (on a form when adding a new session and the course/module are set to allow groups.)
https://github.com/danmarsden/moodle-mod_attendance/blob/6d812f5ea9b8f2fbc0aef679d1a613b205e0ec1b/add_form.php#L96

blocks

MDL-60205 Regression in formslib: hideIf on an element inside a group hides the whole group (Clean only)

MDL-60108 Simplify moodle.net registration form, add new mailing list, show during installation

is a regression caused by

MDL-53848 Formslib - add function to $mform that makes it possible to hide form elements dependent on selected values

Participants:: Andrew Lyons, CiBoT, Dan Marsden, Davo Smith, Eloy Lafuente (stronk7), Marina Glancy, Mark Nelson

Component watchers:: David Woloszyn, Huong Nguyen, Jake Dallimore, Meirza, Michael Hawkins, Raquel Ortega, Safat Shahin, Stevani Andolo