-
Type:
Improvement
-
Status: Closed
-
Priority:
Minor
-
Resolution: Fixed
-
Affects Version/s: 3.1.7, 3.2.4, 3.3.1, 3.4, 3.6
-
Fix Version/s: 3.7
-
Component/s: Blocks, Navigation
-
Labels:
-
Testing Instructions:
-
Affected Branches:MOODLE_31_STABLE, MOODLE_32_STABLE, MOODLE_33_STABLE, MOODLE_34_STABLE, MOODLE_36_STABLE
-
Fixed Branches:MOODLE_37_STABLE
-
Pull from Repository:
-
Pull Master Branch:
MDL-60019-master -
Pull Master Diff URL:
With reference to: https://moodle.org/mod/forum/discuss.php?d=357147 - in '/blocks/navigation/block_navigation.php', method 'get_content' there is the code:
$arguments = array(
'id' => $this->instance->id,
'instance' => $this->instance->id,
'candock' => $this->instance_can_be_docked(),
'courselimit' => $limit,
'expansionlimit' => $expansionlimit
);
Which appears to do nothing! If agreed that it should go, then how do I write / specify a test for this please? Then I'll submit a patch.
- will be (partly) resolved by
-
MDL-64545 Redundant code in block_navigation.php (backport of MDL-60019)
-
- Closed
-