Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-60019

Redundant code in block_navigation.php

    XMLWordPrintable

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 3.1.7, 3.2.4, 3.3.1, 3.4, 3.6
    • Fix Version/s: 3.7
    • Component/s: Blocks, Navigation
    • Labels:

      Description

      With reference to: https://moodle.org/mod/forum/discuss.php?d=357147 - in '/blocks/navigation/block_navigation.php', method 'get_content' there is the code:

      $arguments = array(
      'id' => $this->instance->id,
      'instance' => $this->instance->id,
      'candock' => $this->instance_can_be_docked(),
      'courselimit' => $limit,
      'expansionlimit' => $expansionlimit
      );

      Which appears to do nothing!  If agreed that it should go, then how do I write / specify a test for this please?  Then I'll submit a patch.

        Attachments

          Issue Links

            Activity

              People

              Assignee:
              peterdias Peter Dias
              Reporter:
              gb2048 Gareth J Barnard
              Peer reviewer:
              Mark Nelson
              Integrator:
              Andrew Nicols
              Tester:
              CiBoT
              Participants:
              Component watchers:
              Adrian Greeve, Jake Dallimore, Mathew May, Mihail Geshoski, Peter Dias, Adrian Greeve, Jake Dallimore, Mathew May, Mihail Geshoski, Peter Dias
              Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Fix Release Date:
                20/May/19