[MDL-60028] Count enrolled users can count users more than once when users have been enrolled using different enrollment methods - Moodle Tracker

XML

Word

Printable

Details

Type: Bug
Status: Closed
Priority: Minor
Resolution: Fixed
Affects Version/s: 3.3.1, 3.3.7, 3.4.4, 3.5.1, 3.6
Fix Version/s: 3.4.6, 3.5.3
Component/s: Enrolments
Labels:
- ci
- triaged

Affected Branches:
MOODLE_33_STABLE, MOODLE_34_STABLE, MOODLE_35_STABLE, MOODLE_36_STABLE
Fixed Branches:
MOODLE_34_STABLE, MOODLE_35_STABLE
Pull from Repository:
https://github.com/paulholden/moodle.git
Pull Master Branch:
~~MDL-60028~~
Pull Master Diff URL:
https://github.com/moodle/moodle/compare/master...paulholden:MDL-60028
Testing Instructions:
1. Run vendor/bin/phpunit enrol/tests/enrollib_test.php
2. Confirm testcase passes

Description

When using count_enrolled_users from lib/enrollib.php, and users may have been enrolled in a course by different methods or have several roles, the user count can differ from the actual amount of users.

Attaching a patch that would count the distinct user ids. Optimized for PostgreSQL.

Attachments

- Sort By Name
- Sort By Date
- Ascending
- Descending
- Thumbnails
- List
- Download All

distinct_userids_patch.diff
0.8 kB
06/Sep/17 8:44 AM

Issue Links

has been marked as being related by

MDL-43130 Users assigned context role via multiple components are counted multiple times

Closed

Activity

People

Assignee:: Paul Holden

Reporter:: David Castro

Peer reviewer:: Daniel Neis Araujo

Integrator:: Eloy Lafuente (stronk7)

Tester:: CiBoT

Participants:: CiBoT, Daniel Neis Araujo, David Castro, Eloy Lafuente (stronk7), Paul Holden

Component watchers:: David Woloszyn, Huong Nguyen, Jake Dallimore, Meirza, Michael Hawkins, Raquel Ortega, Safat Shahin, Stevani Andolo

Votes:: 3 Vote for this issue

Watchers:: 4 Start watching this issue

Dates

Created:: 06/Sep/17 8:43 AM

Updated:: 08/Mar/19 8:25 PM

Resolved:: 27/Sep/18 11:11 PM

Fix Release Date:: 12/Nov/18