Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-60031

Risk bitmap icons no longer indicate the risk properly

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 3.3.1
    • Fix Version/s: 3.3.3
    • Component/s: Administration
    • Labels:
    • Testing Instructions:
      Hide
      1. Navigate to Site administration => Users => Permissions => Define roles
      2. Edit a role
      3. Filter to moodle/user:delete
      4. Mouse over the risk bitmap icons
        1. Confirm that the hover title on mouseover is a longer, informative string
      Show
      Navigate to Site administration => Users => Permissions => Define roles Edit a role Filter to moodle/user:delete Mouse over the risk bitmap icons Confirm that the hover title on mouseover is a longer, informative string
    • Affected Branches:
      MOODLE_33_STABLE
    • Fixed Branches:
      MOODLE_33_STABLE
    • Pull Master Branch:
      MDL-60031-master

      Description

      1. Navigate to Site administration => Users => Permissions => Define roles
      2. Edit a role
      3. Filter to moodle/user:delete
      4. Mouse over the risk bitmap icons
      Expected result

      The hover title on mouseover is a longer, informative string

      Actual result

      The hover title shown is a description of the image

      Rationale

      This is a regression from MDL-40759 where the original manually inserted img was replaced with the pix_icon renderer.
      The pix_icon (arguably incorrectly) uses the alt attribute as a default for the title if one was not provided, however it is unaware of any title attribute on a parent element.
      In this instance, the pix_icon is placed within an anchor, and that anchor had the correct title.

      Suggested fix

      Modify the call to instantiate the pix_icon to add a title attribute.
      This could be either an empty string, null, or the actual title depending on which is most appropriate.

      Notes

      This issue only affects Moodle 3.2, and Moodle 3.3

        Attachments

          Activity

            People

            Assignee:
            dobedobedoh Andrew Nicols
            Reporter:
            dobedobedoh Andrew Nicols
            Peer reviewer:
            Simey Lameze
            Integrator:
            Jun Pataleta
            Tester:
            David Mudrák (@mudrd8mz)
            Participants:
            Component watchers:
            Andrew Nicols, Jun Pataleta, Michael Hawkins, Shamim Rezaie, Simey Lameze
            Votes:
            1 Vote for this issue
            Watchers:
            5 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:
              Fix Release Date:
              13/Nov/17