Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-60052

Modal is not honoring the large setting, does not display wider

    XMLWordPrintable

    Details

    • Testing Instructions:
      Hide
      1. Use ngrok
      2. Add "http://lti.tools/test/tp.php" to Site administration > Plugins > Activity modules > External tool > Manage tools
      3. Add an instance of that tool to a course
      4. Press the "Select content" button
        1. Make sure the modal is large (see screenshots for reference)
      5. Go to Users > Enrolled users for the course.
        1. Make sure the model is small
      Show
      Use ngrok Add "http://lti.tools/test/tp.php" to Site administration > Plugins > Activity modules > External tool > Manage tools Add an instance of that tool to a course Press the "Select content" button Make sure the modal is large (see screenshots for reference) Go to Users > Enrolled users for the course. Make sure the model is small
    • Affected Branches:
      MOODLE_32_STABLE, MOODLE_33_STABLE
    • Fixed Branches:
      MOODLE_32_STABLE, MOODLE_33_STABLE
    • Pull from Repository:

      Description

      When opening a modal specifying the large option, the modal is not actually opening wider.

      This is an issue for example in LTI Content Selector as the UI to pick content is usually rich, and does not fit nicely in a tiny modal.

      This seems also as a regression due to style changes (class changing from large to modal-lg).

      Note that this was fixed in 3.4 (master) by MDL-59382 and this ticket is only a backport to 3.2 and 3.3 of the isolated commit fixing that issue alone.

        Attachments

          Issue Links

          has a non-specific relationship to

          Task - A task that needs to be completed. Tasks usually refer to work that must be done outside the product. MDL-59382 Create calendar event quick-add

          • Major - Major loss of function, incorrect output
          • Closed

            Activity

              People

              Assignee:
              claudevervoort Claude Vervoort
              Reporter:
              claudevervoort Claude Vervoort
              Peer reviewer:
              John Okely
              Integrator:
              Andrew Nicols
              Tester:
              Andrew Nicols
              Participants:
              Component watchers:
              Adrian Greeve, Jake Dallimore, Mathew May, Mihail Geshoski, Peter Dias, Sujith Haridasan, Adrian Greeve, Jake Dallimore, Mathew May, Mihail Geshoski, Peter Dias, Sujith Haridasan, Andrew Nicols, Jun Pataleta, Michael Hawkins, Shamim Rezaie, Simey Lameze, Adrian Greeve, Jake Dallimore, Mathew May, Mihail Geshoski, Peter Dias, Sujith Haridasan, Bas Brands, Barbara Ramiro, Bas Brands
              Votes:
              1 Vote for this issue
              Watchers:
              5 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Fix Release Date:
                13/Nov/17