Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-60058

Add support for drag/drop of assign activity action events

    XMLWordPrintable

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 3.4
    • Fix Version/s: 3.4
    • Component/s: Calendar
    • Labels:
    • Testing Instructions:
      Hide

      Notes

      • Please test on both the Clean and Boost themes. You don’t need to run the full set of tests on each theme, you just need to confirm that the drag / drop styling works on both themes.

      Setup

      1. Log in as admin
      2. Create a course
      3. Enrol a user as a teacher (t1)
      4. Enrol a user as a student (s1)

      Assignment due date as teacher

      1. Log in as t1
      2. Create an assignment activity
        • Allow online text as a submission type
        • Enable the cutoff date and set it to a couple of dates after the due date (but before the "Remind me to grade by" date)
        • Make sure all availability dates are set to 8am on their respective days
      3. Click save and display
      4. Click edit settings to return to the assignment settings page
        • Cog icon up the top right > edit settings
      5. In a separate tab or window go to the calendar
      6. View the appropriate month for the due date
      7. Confirm that you see an assignment event for the due date
        • Note: The styling isn’t correct but that’s a separate issue (see MDL-60176)
      8. Start to drag the assignment event
      9. Confirm that the days after the cutoff day are greyed out (the day of the cutoff is still acceptable because setting the due date to the cutoff date is valid, according to the mfrom validation)
      10. Confirm that the days prior to the allow submissions from day are greyed out (same applies as above)
      11. Confirm that you get an error message when you try to drop the event on an invalid day
      12. Confirm that if you drop the event on a valid day that the calendar is updated correctly
      13. Confirm that the due date for the assignment is updated (you can reload the tab with the settings open to see the updated due date value)
        • Note: Only the date for the due date should be updated, the time will not be changed.
      14. In the assignment settings tab change the “Allow submissions from” time from 8am to 8:05am
      15. Change the “cut-off date” time from 8am to 7:55am
      16. Reload the calendar tab
      17. Confirm that the day of the “Allow submissions from” date is no longer a valid drop zone (because the due date has a time of 8am so dropping it there would be earlier than the 8:05 cutoff)
      18. Confirm that the day of the “Cut-off date” is not longer valid (same reasoning as above)
      19. In the assignment settings tab change the cut off date to after the "remind me to grade by" date
      20. Reload the calendar
      21. Confirm that dragging the due date is now bound by the "remind me to grade by" date rather than the "cut-off date" (since it's now the earlier of the two).

      Assignment due date dashboard as teacher

      1. As the teacher
      2. Go to the dashboard
      3. Confirm that you do not see the event for the assignment due date

      Assignment due date as student

      1. Log in as s1
      2. View the calendar
      3. Navigate the calendar to the correct month for the assignment due date
      4. Confirm that you can’t drag the assignment due date event

      Assignment due date dashboard as student

      1. As the student
      2. Go to the dashboard
      3. Confirm that you do see the event for the assignment due date
      4. Navigate to the assignment
      5. Add a submission

      Assignment grading due by as teacher

      1. Log in as t1
      2. Navigate to the calendar and change the month to the assignment grading due event
      3. Confirm That you cannot drag the grading due event before the assignment due event
      4. Confirm that you can drag the grading due event any time after the assignment due event
      5. After you’ve successfully dragged the grading due event to a different day, navigate back to the assignment settings
      6. Confirm that the grading due date was updated (the date will should have changed but the time of day should have remained the same)

      Choice as teacher

      1. Log in as t1
      2. Create a choice activity in the course
        • Enable and set the responses from and responses until date under the “availability” section
      3. Navigate to the calendar and find the two choice events (one for open and one for close)
      4. Confirm that you see the visual indicators telling you that you can’t drag the close event before the open event (the same rules apply here regarding the time of day as the events in the assignment)
      5. Confirm that you see the visual indicators telling you that you can’t drag the open event after the close event (the same rules apply here regarding the time of day as the events in the assignment)
      6. Confirm that when you drop the events in a valid drop zone that the choice activity is updated correctly (you can see it by editing the settings of the activity).

      Choice as a student

      1. Log in as s1
      2. Navigate to the calendar and month with the choice events
      3. Confirm that you can’t drag the choice events

      General

      1. Logged in as any user
      2. Go to the calendar
      3. Confirm that dragging a random link on the page doesn’t turn on any of the calendar drag/drop UI
      4. Confirm that dragging and dropping a random link from elsewhere on the page into the calendar doesn't do anything
      Show
      Notes Please test on both the Clean and Boost themes. You don’t need to run the full set of tests on each theme, you just need to confirm that the drag / drop styling works on both themes. Setup Log in as admin Create a course Enrol a user as a teacher (t1) Enrol a user as a student (s1) Assignment due date as teacher Log in as t1 Create an assignment activity Allow online text as a submission type Enable the cutoff date and set it to a couple of dates after the due date (but before the "Remind me to grade by" date) Make sure all availability dates are set to 8am on their respective days Click save and display Click edit settings to return to the assignment settings page Cog icon up the top right > edit settings In a separate tab or window go to the calendar View the appropriate month for the due date Confirm that you see an assignment event for the due date Note: The styling isn’t correct but that’s a separate issue (see MDL-60176 ) Start to drag the assignment event Confirm that the days after the cutoff day are greyed out (the day of the cutoff is still acceptable because setting the due date to the cutoff date is valid, according to the mfrom validation) Confirm that the days prior to the allow submissions from day are greyed out (same applies as above) Confirm that you get an error message when you try to drop the event on an invalid day Confirm that if you drop the event on a valid day that the calendar is updated correctly Confirm that the due date for the assignment is updated (you can reload the tab with the settings open to see the updated due date value) Note: Only the date for the due date should be updated, the time will not be changed. In the assignment settings tab change the “Allow submissions from” time from 8am to 8:05am Change the “cut-off date” time from 8am to 7:55am Reload the calendar tab Confirm that the day of the “Allow submissions from” date is no longer a valid drop zone (because the due date has a time of 8am so dropping it there would be earlier than the 8:05 cutoff) Confirm that the day of the “Cut-off date” is not longer valid (same reasoning as above) In the assignment settings tab change the cut off date to after the "remind me to grade by" date Reload the calendar Confirm that dragging the due date is now bound by the "remind me to grade by" date rather than the "cut-off date" (since it's now the earlier of the two). Assignment due date dashboard as teacher As the teacher Go to the dashboard Confirm that you do not see the event for the assignment due date Assignment due date as student Log in as s1 View the calendar Navigate the calendar to the correct month for the assignment due date Confirm that you can’t drag the assignment due date event Assignment due date dashboard as student As the student Go to the dashboard Confirm that you do see the event for the assignment due date Navigate to the assignment Add a submission Assignment grading due by as teacher Log in as t1 Navigate to the calendar and change the month to the assignment grading due event Confirm That you cannot drag the grading due event before the assignment due event Confirm that you can drag the grading due event any time after the assignment due event After you’ve successfully dragged the grading due event to a different day, navigate back to the assignment settings Confirm that the grading due date was updated (the date will should have changed but the time of day should have remained the same) Choice as teacher Log in as t1 Create a choice activity in the course Enable and set the responses from and responses until date under the “availability” section Navigate to the calendar and find the two choice events (one for open and one for close) Confirm that you see the visual indicators telling you that you can’t drag the close event before the open event (the same rules apply here regarding the time of day as the events in the assignment) Confirm that you see the visual indicators telling you that you can’t drag the open event after the close event (the same rules apply here regarding the time of day as the events in the assignment) Confirm that when you drop the events in a valid drop zone that the choice activity is updated correctly (you can see it by editing the settings of the activity). Choice as a student Log in as s1 Navigate to the calendar and month with the choice events Confirm that you can’t drag the choice events General Logged in as any user Go to the calendar Confirm that dragging a random link on the page doesn’t turn on any of the calendar drag/drop UI Confirm that dragging and dropping a random link from elsewhere on the page into the calendar doesn't do anything
    • Affected Branches:
      MOODLE_34_STABLE
    • Fixed Branches:
      MOODLE_34_STABLE
    • Pull Master Branch:
      MDL-60058-master-4

      Description

      Allow the action events created by the assign activity to be dragged and dropped in the calendar UI.

        Attachments

          Issue Links

            Activity

              People

              • Votes:
                0 Vote for this issue
                Watchers:
                6 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  13/Nov/17