Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-60063

Add support for drag/drop of feedback activity action events

    XMLWordPrintable

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 3.4
    • Fix Version/s: 3.4
    • Component/s: Calendar
    • Labels:
    • Testing Instructions:
      Hide

      Setup

      1. Log in as admin
      2. Create a course
      3. Enrol a student in the course (s1)
      4. Enrol a teacher in the course (t1)
      5. Create a feedback activity
        • Set “Allow answers from” to yesterday at 8am
        • Set “Allow answers to” to two days from now at 8am
      6. Add a question to the feedback

      Feedback disappears from dashboard

      1. Log in as s1
      2. View your dashboard
      3. Confirm that you see the event for feedback closing
      4. Click the “Answer the questions” link
      5. Complete the feedback by answering the question
      6. Return to the dashboard
      7. Confirm that the event is no longer visible

      Calendar as student

      1. Log in as s1
      2. Navigate to the calendar
      3. Confirm that you can’t drag either of the feedback events

      Calendar as t1

      1. Log in as t1
      2. Navigate to the calendar
      3. Confirm that you see the feedback open event
      4. Confirm that you see the feedback close event
      5. Start to drag the feedback open event
      6. Confirm that the days after the feedback close day are greyed out (the day of the feedback close is still acceptable because setting the open date to the close date is valid, according to the mfrom validation)
      7. Confirm that you get an error message when you try to drop the event on an invalid day
      8. Confirm that if you drop the event on a valid day that the calendar is updated correctly
      9. Confirm that the "Allow answers from" date for the feedback is updated (you can open to activity settings in another tab to see that the date has changed)
        • Note: Only the date for the feedback open should be updated, the time will not be changed.
      10. Start to drag the feedback close event
      11. Confirm that the days before the feedback open event are greyed out (invalid drop zones)
      12. In the feedback settings tab change the “Allow answers to” time from 8am 7:55am
      13. Go to the calendar tab and reload it
      14. Start to drag the feedback open event
      15. Confirm that the day of the “Allow answers to” date is no longer a valid drop zone (because the “Allow answers from” has a time of 7:55am so dropping it there would be later since the from date is set to 8am)
      16. Start to drag the feedback close event
      17. Confirm that the day for the open event is not a valid drop zone (because 7:55am is earlier than the 8am cutoff from the open event).
      18. Confirm that if you drop the event on a valid day that the calendar is updated correctly
      19. Confirm that the "Allow answers to" date for the feedback is updated (you can open to activity settings in another tab to see that the date has changed)
      Show
      Setup Log in as admin Create a course Enrol a student in the course (s1) Enrol a teacher in the course (t1) Create a feedback activity Set “Allow answers from” to yesterday at 8am Set “Allow answers to” to two days from now at 8am Add a question to the feedback Feedback disappears from dashboard Log in as s1 View your dashboard Confirm that you see the event for feedback closing Click the “Answer the questions” link Complete the feedback by answering the question Return to the dashboard Confirm that the event is no longer visible Calendar as student Log in as s1 Navigate to the calendar Confirm that you can’t drag either of the feedback events Calendar as t1 Log in as t1 Navigate to the calendar Confirm that you see the feedback open event Confirm that you see the feedback close event Start to drag the feedback open event Confirm that the days after the feedback close day are greyed out (the day of the feedback close is still acceptable because setting the open date to the close date is valid, according to the mfrom validation) Confirm that you get an error message when you try to drop the event on an invalid day Confirm that if you drop the event on a valid day that the calendar is updated correctly Confirm that the "Allow answers from" date for the feedback is updated (you can open to activity settings in another tab to see that the date has changed) Note: Only the date for the feedback open should be updated, the time will not be changed. Start to drag the feedback close event Confirm that the days before the feedback open event are greyed out (invalid drop zones) In the feedback settings tab change the “Allow answers to” time from 8am 7:55am Go to the calendar tab and reload it Start to drag the feedback open event Confirm that the day of the “Allow answers to” date is no longer a valid drop zone (because the “Allow answers from” has a time of 7:55am so dropping it there would be later since the from date is set to 8am) Start to drag the feedback close event Confirm that the day for the open event is not a valid drop zone (because 7:55am is earlier than the 8am cutoff from the open event). Confirm that if you drop the event on a valid day that the calendar is updated correctly Confirm that the "Allow answers to" date for the feedback is updated (you can open to activity settings in another tab to see that the date has changed)
    • Affected Branches:
      MOODLE_34_STABLE
    • Fixed Branches:
      MOODLE_34_STABLE
    • Pull Master Branch:
      MDL-60063-master-2

      Description

      Allow the action events created by the feedback activity to be dragged and dropped in the calendar UI.

        Attachments

          Issue Links

            Activity

              People

              • Votes:
                0 Vote for this issue
                Watchers:
                5 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  13/Nov/17