Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-60079

User tours leave unnecessary aria tags in the page

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 3.2.4, 3.3.1, 3.4
    • Fix Version/s: 3.3.4, 3.4.1
    • Component/s: User Tours
    • Labels:
    • Testing Instructions:
      Hide
      1. Log in as admin
      2. Go to Site administration / Appearance / User tours.
      3. Ensure that editing mode is off (you will see "Add an activity or resource" if it is, you can switch it off by going to the action menu in the header and selecting "Turn editing off")
      4. Edit "Boost - administrator tour" and select "All" for "Role" setting
      5. Click on "Boost - administrator tour" link to access the tour steps
      6. Follow "force the tour to be displayed" link
      7. Go to the site home page so the user tour is executed
      8. Click Next twice, to get to the third step of the tour, about Customisation.
      9. Click End tour.
      10. User your browser's developer tools to inspect your site header (you can search for "#page-header .card-block")
      11. There should not be any "aria-describedby" attribute
      Show
      Log in as admin Go to Site administration / Appearance / User tours. Ensure that editing mode is off (you will see "Add an activity or resource" if it is, you can switch it off by going to the action menu in the header and selecting "Turn editing off") Edit "Boost - administrator tour" and select "All" for "Role" setting Click on "Boost - administrator tour" link to access the tour steps Follow "force the tour to be displayed" link Go to the site home page so the user tour is executed Click Next twice, to get to the third step of the tour, about Customisation. Click End tour. User your browser's developer tools to inspect your site header (you can search for "#page-header .card-block") There should not be any "aria-describedby" attribute
    • Affected Branches:
      MOODLE_32_STABLE, MOODLE_33_STABLE, MOODLE_34_STABLE
    • Fixed Branches:
      MOODLE_33_STABLE, MOODLE_34_STABLE
    • Pull from Repository:
    • Pull 3.4 Branch:
    • Pull 3.4 Diff URL:
    • Pull Master Branch:
      MDL-60079-master
    • Pull Master Diff URL:

      Description

      Steps to reproduce:

      1. Go to qa.moodle.net, and log in as manager.
      2. Go to Site administration / Appearance / User tours.
      3. Edit the properties on the Boost - administrator tour, to show to all roles.
      4. Go to the site home page.
      5. Click Next twice, to get to the third step of the tour, about Customisation.
      6. Click End tour.
      7. User your browser's developer tools to inspect the 'Moodle QA Testing Site' header.

      Actual result: one of the surrounding divs still has aria-describedby="tour-step-tool_usertours_6_1_1479366244-2-body" even though that thing no longer exists in the page.

      There is also one left on div.drawer-toggle > button, from the second step.

      Expected result: these aria attributes should be removen when you leave that step of the tour.

        Attachments

          Issue Links

          Testing discovered

          Bug - A problem which impairs or prevents Moodle from functioning correctly. MDL-61234 User tours race condition

          • Minor - Minor loss of function where workaround is possible
          • Closed

            Activity

              People

              • Votes:
                0 Vote for this issue
                Watchers:
                6 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  15/Jan/18