Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-60129

Not all activites support deleting tags during course reset

    XMLWordPrintable

Details

    • Improvement
    • Status: Closed
    • Minor
    • Resolution: Fixed
    • 3.3
    • 3.4
    • Book, Forum, Glossary, Tags
    • MOODLE_33_STABLE
    • MOODLE_34_STABLE
    • MDL-60129_master-v2
    • Hide
      Prerequisite.
      1. Ensure tagging is enabled on your site.
      Test 1
      1. Create a course.
      2. Create a book.
      3. Add a chapter to the book with a tag.
      4. Go to the course reset page.
      5. Do not check anything.
      6. Submit the form.
      7. Look at the chapter in the book and confirm the tag is still there.
      8. Go to the course reset page.
      9. Check to remove the book tags.
      10. Submit the form.
      11. Confirm you get a message saying that the book tags have been removed.
      12. Look at the chapter in the book and confirm the tag is no longer there.
      Test 2
      1. Create a forum.
      2. Add a discussion to the forum with a tag.
      3. Go to the course reset page.
      4. Do not check anything.
      5. Submit the form.
      6. Look at the discussion in the forum and confirm the tag is still there.
      7. Go to the course reset page.
      8. Check to delete all forum posts.
      9. Confirm the 'Remove all forum tags' checkbox becomes disabled.
      10. Submit the form.
      11. Confirm you get a message saying that the forum posts have been removed.
      12. Click on the forum and confirm all posts have been deleted.
      13. Run php admin/tool/task/cli/schedule_task.php --execute=\\core\\task
        tag_cron_task
      14. Look in your 'mdl_tag' table and confirm the tags were deleted as well.
      Test 3
      1. Create a forum.
      2. Add a discussion to the forum with a tag.
      3. Go to the course reset page.
      4. Check to remove all forum tags.
      5. Submit the form.
      6. Confirm you get a message saying that the forum tags have been removed.
      7. Click on the forum and confirm all the tags have been deleted.
      Test 4
      1. Create a glossary.
      2. Add an entry to the glossary with a tag.
      3. Go to the course reset page.
      4. Do not check anything.
      5. Submit the form.
      6. Look at the entry in the glossary and confirm the tag is still there.
      7. Go to the course reset page.
      8. Check to delete all glossary entries.
      9. Confirm the 'Remove all glossary tags' checkbox becomes disabled.
      10. Submit the form.
      11. Confirm you get a message saying that the glossary entries have been removed.
      12. Click on the glossary and confirm all entries have been deleted.
      13. Run php admin/tool/task/cli/schedule_task.php --execute=\\core\\task
        tag_cron_task
      14. Look in your 'mdl_tag' table and confirm the tags were deleted as well.
      Test 5
      1. Create a glossary.
      2. Add an entry to the glossary with a tag.
      3. Go to the course reset page.
      4. Check to remove all glossary tags.
      5. Submit the form.
      6. Confirm you get a message saying that the glossary tags have been removed.
      7. Click on the glossary and confirm all the tags have been deleted.
      Show
      Prerequisite. Ensure tagging is enabled on your site. Test 1 Create a course. Create a book. Add a chapter to the book with a tag. Go to the course reset page. Do not check anything. Submit the form. Look at the chapter in the book and confirm the tag is still there. Go to the course reset page. Check to remove the book tags. Submit the form. Confirm you get a message saying that the book tags have been removed. Look at the chapter in the book and confirm the tag is no longer there. Test 2 Create a forum. Add a discussion to the forum with a tag. Go to the course reset page. Do not check anything. Submit the form. Look at the discussion in the forum and confirm the tag is still there. Go to the course reset page. Check to delete all forum posts. Confirm the 'Remove all forum tags' checkbox becomes disabled. Submit the form. Confirm you get a message saying that the forum posts have been removed. Click on the forum and confirm all posts have been deleted. Run php admin/tool/task/cli/schedule_task.php --execute=\\core\\task tag_cron_task Look in your 'mdl_tag' table and confirm the tags were deleted as well. Test 3 Create a forum. Add a discussion to the forum with a tag. Go to the course reset page. Check to remove all forum tags. Submit the form. Confirm you get a message saying that the forum tags have been removed. Click on the forum and confirm all the tags have been deleted. Test 4 Create a glossary. Add an entry to the glossary with a tag. Go to the course reset page. Do not check anything. Submit the form. Look at the entry in the glossary and confirm the tag is still there. Go to the course reset page. Check to delete all glossary entries. Confirm the 'Remove all glossary tags' checkbox becomes disabled. Submit the form. Confirm you get a message saying that the glossary entries have been removed. Click on the glossary and confirm all entries have been deleted. Run php admin/tool/task/cli/schedule_task.php --execute=\\core\\task tag_cron_task Look in your 'mdl_tag' table and confirm the tags were deleted as well. Test 5 Create a glossary. Add an entry to the glossary with a tag. Go to the course reset page. Check to remove all glossary tags. Submit the form. Confirm you get a message saying that the glossary tags have been removed. Click on the glossary and confirm all the tags have been deleted.

    Description

      mod/book/lang/en/book.php:$string['tagsdeleted'] = 'Book tags have been deleted';
      		 
      mod/forum/lang/en/forum.php:$string['tagsdeleted'] = 'Forum tags have been deleted';
      		 
      mod/glossary/lang/en/glossary.php:$string['tagsdeleted'] = 'Glossary tags have been deleted';
      		 
      mod/wiki/lang/en/wiki.php:$string['tagsdeleted'] = 'Wiki tags have been deleted';
      		 
      mod/wiki/lib.php:                $status[] = array('component' => $componentstr, 'item' => get_string('tagsdeleted', 'wiki'), 'error' => false);


      mod/book/lang/en/book.php:$string['removeallbooktags'] = 'Remove all book tags';
      		 
      mod/forum/lang/en/forum.php:$string['removeallforumtags'] = 'Remove all forum tags';
      		 
      mod/glossary/lang/en/glossary.php:$string['removeallglossarytags'] = 'Remove all glossary tags';
      		 
      mod/wiki/lang/en/wiki.php:$string['removeallwikitags'] = 'Remove all wiki tags';
      		 
      mod/wiki/lib.php:    $mform->addElement('advcheckbox', 'reset_wiki_tags', get_string('removeallwikitags', 'wiki'));

      The modules implement the string 'tagsdeleted' and 'removeallxyztags' but only wiki supports this functionality.

      In 3.2 the only activity that supports tagging is the wiki modules, so this is only an issue in 3.3 and above.

      Attachments

        Issue Links

          Discovered while testing

          Improvement - An enhancement to an existing Moodle feature. MDL-57455 Tagging database entries

          • Minor - Minor loss of function where workaround is possible
          • Closed
          has a QA test

          Functional Test - A test of a single Moodle feature MDLQA-16748 Activity tags are deleted during course reset

          • Minor - Minor loss of function where workaround is possible
          • Open

          Functional Test - A test of a single Moodle feature MDLQA-17362 CLONE - Activity tags are deleted during course reset

          • Minor - Minor loss of function where workaround is possible
          • Passed

          Functional Test - A test of a single Moodle feature MDLQA-17912 CLONE - Activity tags are deleted during course reset

          • Minor - Minor loss of function where workaround is possible
          • Passed

          Activity

            People

              markn Mark Nelson
              markn Mark Nelson
              John Okely John Okely
              Eloy Lafuente (stronk7) Eloy Lafuente (stronk7)
              Adrian Greeve Adrian Greeve
              David Jones, Ilya Tregubov, Kevin Percy, Mathew May, Mihail Geshoski, Shamim Rezaie, Adrian Greeve, Ilya Tregubov, Kevin Percy, Mathew May, Mihail Geshoski, Shamim Rezaie, Ilya Tregubov, Kevin Percy, Mathew May, Mihail Geshoski, Shamim Rezaie, David Woloszyn, Huong Nguyen, Jake Dallimore, Meirza, Michael Hawkins, Raquel Ortega, Safat Shahin, Stevani Andolo
              Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:
                13/Nov/17