Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-60132

URLs returned by tool_mobile are not being handled correctly

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 3.2.3, 3.3.2, 3.4
    • Fix Version/s: 3.2.6, 3.3.3
    • Component/s: Web Services
    • Labels:
    • Testing Instructions:
      Hide
      1. As admin, enable "Mobile services": Site administration ► Mobile app ► Mobile settings
      2. Install the Theme aardvark https://github.com/superawesomeme/moodle-theme_aardvark (use the correct branch from github)
      3. Enable the theme, and add a logo and small logo via the theme settings
      4. Now, set the grade_mygrades_report admin setting to External
      5. Set the gradereport_mygradeurl admin setting to any url (different than the site), https://moodle.net for example
      6. Connect with the Mobile app to your site
      7. Check that you can log-in correctly in the site with a normal user account
      Show
      As admin, enable "Mobile services": Site administration ► Mobile app ► Mobile settings Install the Theme aardvark https://github.com/superawesomeme/moodle-theme_aardvark (use the correct branch from github) Enable the theme, and add a logo and small logo via the theme settings Now, set the grade_mygrades_report admin setting to External Set the gradereport_mygradeurl admin setting to any url (different than the site), https://moodle.net for example Connect with the Mobile app to your site Check that you can log-in correctly in the site with a normal user account
    • Affected Branches:
      MOODLE_32_STABLE, MOODLE_33_STABLE, MOODLE_34_STABLE
    • Fixed Branches:
      MOODLE_32_STABLE, MOODLE_33_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-60132-master

      Description

      It happens that in Moodle there are some functions that can be overridden by renderers that instead of returning moodle_url objects are returning plain string urls.

      This is a bug in the plugin implementing the function (it's not being returned the type expected) but we should avoid a direct impact of the plugin errors in Web Services.

        Attachments

          Issue Links

            Activity

              People

              • Votes:
                0 Vote for this issue
                Watchers:
                4 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  13/Nov/17