Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-6017

missing lang string on restore

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Trivial
    • Resolution: Fixed
    • Affects Version/s: 1.6
    • Fix Version/s: 1.6.6, 1.7.3, 1.8.3
    • Component/s: Backup
    • Labels:
      None
    • Environment:
      All
    • Affected Branches:
      MOODLE_16_STABLE
    • Fixed Branches:
      MOODLE_16_STABLE, MOODLE_17_STABLE, MOODLE_18_STABLE

      Description

      There is a missing lang string somewhere. On restore I get this:

      ? Creating gradebook

      o [[respectingcurrentdata]]

        Gliffy Diagrams

          Attachments

            Activity

            Hide
            aborrow Anthony Borrow added a comment -

            Eloy - I believe the language file is grades (not grade). I found 2 such errors in /backup/restorelib.php v 1.218.2.21 (lines 1210 and 1221) which currently are:

            1210 - echo '<li>'.get_string('backupwithoutgradebook','grade').'</li>';
            1221 - echo '<li>'.get_string('respectingcurrentdata','grade').'</li>';

            I think they should be:

            1210 - echo '<li>'.get_string('backupwithoutgradebook','grades').'</li>';
            1221 - echo '<li>'.get_string('respectingcurrentdata','grades').'</li>';

            then these strings need to be added to /lang/en_utf8/grades.php

            I'm attaching a diff file.

            Show
            aborrow Anthony Borrow added a comment - Eloy - I believe the language file is grades (not grade). I found 2 such errors in /backup/restorelib.php v 1.218.2.21 (lines 1210 and 1221) which currently are: 1210 - echo '<li>'.get_string('backupwithoutgradebook','grade').'</li>'; 1221 - echo '<li>'.get_string('respectingcurrentdata','grade').'</li>'; I think they should be: 1210 - echo '<li>'.get_string('backupwithoutgradebook','grades').'</li>'; 1221 - echo '<li>'.get_string('respectingcurrentdata','grades').'</li>'; then these strings need to be added to /lang/en_utf8/grades.php I'm attaching a diff file.
            Hide
            aborrow Anthony Borrow added a comment -

            diff file for /backup/restorelib.php

            Show
            aborrow Anthony Borrow added a comment - diff file for /backup/restorelib.php
            Hide
            aborrow Anthony Borrow added a comment -

            I'm not sure what these strings should say. They were added by you in version 1.138 (http://moodle.cvs.sourceforge.net/moodle/moodle/backup/restorelib.php?revision=1.138&view=markup&pathrev=MOODLE_18_STABLE) in case you don't remember what you did over 2 years ago. Thanks for all of your work and continued contributions to Moodle. Peace - Anthony

            Show
            aborrow Anthony Borrow added a comment - I'm not sure what these strings should say. They were added by you in version 1.138 ( http://moodle.cvs.sourceforge.net/moodle/moodle/backup/restorelib.php?revision=1.138&view=markup&pathrev=MOODLE_18_STABLE ) in case you don't remember what you did over 2 years ago. Thanks for all of your work and continued contributions to Moodle. Peace - Anthony
            Hide
            stronk7 Eloy Lafuente (stronk7) added a comment -

            This has been fixed from Moodle 1.6 to Moodle 1.8. Will be available in next nightly builds (+ versions) or by direct access to CVS.

            Note that these strings are OUT from Moodle under the upcoming 1.9 release so translators don't need to do anything with them in HEAD langs.

            Thanks and ciao

            Show
            stronk7 Eloy Lafuente (stronk7) added a comment - This has been fixed from Moodle 1.6 to Moodle 1.8. Will be available in next nightly builds (+ versions) or by direct access to CVS. Note that these strings are OUT from Moodle under the upcoming 1.9 release so translators don't need to do anything with them in HEAD langs. Thanks and ciao

              People

              • Votes:
                2 Vote for this issue
                Watchers:
                1 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  11/Oct/07