Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-60187

Editing LTI title inline makes it appear in gradebook even If the privacy option "Accept grades from the tool" is disabled

    XMLWordPrintable

    Details

    • Testing Instructions:
      Hide

      Scenario 1

      1. Start with a site on stable.
      2. Use ngrok or anything you might need to make your site publicly available
      3. Create an LTI instance name "LTI"
        1. Use http://lti.tools/test/tp.php as the launch url, "secret" as the secret, and anything as the key (it can't be empty)
        2. Turn accepts grades is off (privacy group)
      4. Rename the instance on the course page "LTI gradebook"
      5. Check the gradebook
      6. Make sure the "LTI gradebook" is shown in the gradebook
      7. Now upgrade to latest integration.
      8. Check the gradebook
      9. Make sure "LTI gradebook" is gone from the gradebook

      Scenario 2

      1. Create a LTI instance name "LTI outcomes"
        • Use http://lti.tools/test/tp.php as the launch url, "secret" as the secret, and anything as the key (it can't be empty)
        • Turn accepts grades is ON (privacy group)
      2. Open the instance
      3. Go to Outcomes 1
      4. Press update
      5. Insert a grade between 0 and 1
      6. Check the gradebook
        • Make sure LTI activity shows up and the score has been updated
      7. Rename the LTI activity
      8. Check the gradebook
        • Make sure the new name is shown
      9. Edit the settings for the LTI instance
      10. Turn accepts grades off
      11. Open the instance
      12. Check the gradebook
        • Make sure it doesn't show up
      Show
      Scenario 1 Start with a site on stable. Use ngrok or anything you might need to make your site publicly available Create an LTI instance name "LTI" Use http://lti.tools/test/tp.php as the launch url, "secret" as the secret, and anything as the key (it can't be empty) Turn accepts grades is off (privacy group) Rename the instance on the course page "LTI gradebook" Check the gradebook Make sure the "LTI gradebook" is shown in the gradebook Now upgrade to latest integration. Check the gradebook Make sure "LTI gradebook" is gone from the gradebook Scenario 2 Create a LTI instance name "LTI outcomes" Use http://lti.tools/test/tp.php as the launch url, "secret" as the secret, and anything as the key (it can't be empty) Turn accepts grades is ON (privacy group) Open the instance Go to Outcomes 1 Press update Insert a grade between 0 and 1 Check the gradebook Make sure LTI activity shows up and the score has been updated Rename the LTI activity Check the gradebook Make sure the new name is shown Edit the settings for the LTI instance Turn accepts grades off Open the instance Check the gradebook Make sure it doesn't show up
    • Affected Branches:
      MOODLE_31_STABLE, MOODLE_32_STABLE, MOODLE_33_STABLE
    • Fixed Branches:
      MOODLE_33_STABLE, MOODLE_34_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-60187_master

      Description

      Possible regression caused by MDL-37168

      If the privacy option "Accept grades from the tool" is disabled, the module does not appear in the gradebook at all. However if the title is edited inline then it does appear.

        Attachments

          Issue Links

            Activity

              People

              • Votes:
                2 Vote for this issue
                Watchers:
                12 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  15/Jan/18