Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-60210

admin/search.php does not check if moodle needs upgrading

    XMLWordPrintable

Details

    • MOODLE_33_STABLE
    • MOODLE_32_STABLE, MOODLE_33_STABLE
    • MDL-60210-master-upgradecheck
    • Hide
      1. Modify moodle_needs_upgrading() so that it shows a debugging notice or error_log or something so you know it has been visited.
      2. Visit admin/search.php page (e.g. by clicking the Site administration link in Boost)
      3. Make sure the function was called.
      Show
      Modify moodle_needs_upgrading() so that it shows a debugging notice or error_log or something so you know it has been visited. Visit admin/search.php page (e.g. by clicking the Site administration link in Boost) Make sure the function was called.

    Description

      On pages where admins typically end at after logging in, moodle performs moodle_needs_upgrading() call to see if a database upgrade is needed. These pages include index.php, admin/index.php, and my/index.php. The check helps to avoid the situation when the site is used in the unstable state of mismatch between the code and the datanbase version.

      The page admin/search.php has not been executing that check, yet it is used as the default Site administration page. So even if administrators follow the good old instruction "follow the Site administration link", no upgrade was actually triggered unless they explicitly visit the Notification page.

      In MDL-60167, marina showed that this can easily lead to serious problems with data integrity. We should not leave the site unattended in the middle of the upgrade and we can help this by putting the page admin/search.php into the list of pages where we execute the upgrade check. It should behave same as my/index.php

      Attachments

        Issue Links

          Activity

            People

              mudrd8mz David Mudrák (@mudrd8mz)
              mudrd8mz David Mudrák (@mudrd8mz)
              Ankit Agarwal Ankit Agarwal
              Andrew Lyons Andrew Lyons
              Andrew Lyons Andrew Lyons
              Andrew Lyons, Huong Nguyen, Jun Pataleta, Michael Hawkins, Shamim Rezaie, Simey Lameze
              Votes:
              2 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:
                13/Nov/17