Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-60210

admin/search.php does not check if moodle needs upgrading

    XMLWordPrintable

    Details

    • Testing Instructions:
      Hide
      1. Modify moodle_needs_upgrading() so that it shows a debugging notice or error_log or something so you know it has been visited.
      2. Visit admin/search.php page (e.g. by clicking the Site administration link in Boost)
      3. Make sure the function was called.
      Show
      Modify moodle_needs_upgrading() so that it shows a debugging notice or error_log or something so you know it has been visited. Visit admin/search.php page (e.g. by clicking the Site administration link in Boost) Make sure the function was called.
    • Affected Branches:
      MOODLE_33_STABLE
    • Fixed Branches:
      MOODLE_32_STABLE, MOODLE_33_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-60210-master-upgradecheck

      Description

      On pages where admins typically end at after logging in, moodle performs moodle_needs_upgrading() call to see if a database upgrade is needed. These pages include index.php, admin/index.php, and my/index.php. The check helps to avoid the situation when the site is used in the unstable state of mismatch between the code and the datanbase version.

      The page admin/search.php has not been executing that check, yet it is used as the default Site administration page. So even if administrators follow the good old instruction "follow the Site administration link", no upgrade was actually triggered unless they explicitly visit the Notification page.

      In MDL-60167, Marina Glancy showed that this can easily lead to serious problems with data integrity. We should not leave the site unattended in the middle of the upgrade and we can help this by putting the page admin/search.php into the list of pages where we execute the upgrade check. It should behave same as my/index.php

        Attachments

          Issue Links

            Activity

              People

              • Votes:
                2 Vote for this issue
                Watchers:
                4 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  13/Nov/17