Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-60219

LTI launch container setting "Embed, without blocks" does not meet expectations anymore in Boost

    XMLWordPrintable

    Details

    • Testing Instructions:
      Hide

      Prerequisites

      1. Login to Moodle as admin
      2. Create a course and enrol a teacher
      3. Login to Moodle as this teacher
      4. Turn editing on.
      5. Add the Activities block to the course homepage.
      6. Configure it and set "Display on page types" to "Any page".
      7. Save the changes.

      Test 1

      1. Create an LTI activity (External tool).
      2. Set the Tool URL to http://lti.tools/test/tp.php
      3. Click "Show more..."
      4. Set the "Launch container" to "Embed, without blocks"
      5. Click "Save and return to course"
      6. Back on the course page, turn editing off.
      7. Click on the LTI activity link.
      8. Check the LTI activity on Boost theme
        • Confirm that you see the Moodle navigation panel, the course header and the LTI provider page.
        • Confirm that you don't see the activities block which you have created on the course homepage.
      9. Check the LTI activity on Clean theme
        • Confirm that you see the Moodle navigation, the course header and the LTI provider page.
        • Confirm that you don't see the activities block which you have created on the course homepage.

      Test 2

      1. Switch to Boost theme.
      2. Turn editing on.
      3. Edit the LTI activity (External tool) by clicking on the actions (gear) icon.
      4. This time, set the "Launch container" to "Embed"
      5. Click "Save and return to course"
      6. Back on the course page, turn editing off.
      7. Click on the LTI activity link.
      8. Check the LTI activity on Boost theme
        • Confirm that you see the Moodle navigation panel, the course header and the LTI provider page.
        • Confirm that you also see the activities block which you have created on the course homepage.
      9. Check the LTI activity on Clean theme
        • Confirm that you see the Moodle navigation, the course header and the LTI provider page.
        • Confirm that you also see the activities block which you have created on the course homepage.
      Show
      Prerequisites Login to Moodle as admin Create a course and enrol a teacher Login to Moodle as this teacher Turn editing on. Add the Activities block to the course homepage. Configure it and set " Display on page types " to " Any page ". Save the changes. Test 1 Create an LTI activity (External tool). Set the Tool URL to http://lti.tools/test/tp.php Click " Show more... " Set the " Launch container " to " Embed, without blocks " Click " Save and return to course " Back on the course page, turn editing off. Click on the LTI activity link. Check the LTI activity on Boost theme Confirm that you see the Moodle navigation panel, the course header and the LTI provider page. Confirm that you don't see the activities block which you have created on the course homepage. Check the LTI activity on Clean theme Confirm that you see the Moodle navigation, the course header and the LTI provider page. Confirm that you don't see the activities block which you have created on the course homepage. Test 2 Switch to Boost theme. Turn editing on. Edit the LTI activity (External tool) by clicking on the actions (gear) icon. This time, set the " Launch container " to " Embed " Click " Save and return to course " Back on the course page, turn editing off. Click on the LTI activity link. Check the LTI activity on Boost theme Confirm that you see the Moodle navigation panel, the course header and the LTI provider page. Confirm that you also see the activities block which you have created on the course homepage. Check the LTI activity on Clean theme Confirm that you see the Moodle navigation, the course header and the LTI provider page. Confirm that you also see the activities block which you have created on the course homepage.
    • Affected Branches:
      MOODLE_32_STABLE, MOODLE_33_STABLE
    • Fixed Branches:
      MOODLE_33_STABLE, MOODLE_34_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-60219-master
    • Pull Master Diff URL:

      Description

      The LTI activity supports a "Launch container" setting which can be set to several values.
      There are two values which promise to embed the LTI provider into Moodle:

      • Embed
      • Embed, without blocks

      As a teacher / admin / student, I would understand "embed" in a way that I still have the Moodle navigation at hand and can use the LTI provider as any other Moodle activity.

      With Theme Clean, this expectation is fulfilled. With Theme Boost, we have seen that it is not.

      This is because in /mod/lti/view.php, the pagelayout is switched to "frametop" if the "Launch container" is set to "Embed, without blocks".

      There are multiple arguments against this pagelayout for LTI in Boost:

      Summing up, setting the pagelayout to frametop when "Embed, without blocks" is selected, does not make sense nowadays. Instead, I propose to also set it to the incourse pagelayout for these reasons:

      • In Boost, the result is exactly what "Embed, without blocks" promises.
      • In Clean, the result is basically the same for incourse as for frametop.

        Attachments

          Activity

            People

            Assignee:
            abias Alexander Bias
            Reporter:
            abias Alexander Bias
            Peer reviewer:
            Ryan Wyllie
            Integrator:
            Damyon Wiese
            Tester:
            Rayna Mae Jayco
            Participants:
            Component watchers:
            Adrian Greeve, Jake Dallimore, Mathew May, Mihail Geshoski, Peter Dias, Sujith Haridasan, Bas Brands
            Votes:
            2 Vote for this issue
            Watchers:
            7 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:
              Fix Release Date:
              15/Jan/18