Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-60243

Non-deterministic ordering in competency/tests/api_test.php

    XMLWordPrintable

    Details

    • Testing Instructions:
      Hide

      For each branch:

      1. Run the attached testloop.sh file in the root of your moodle install, with an unpatched install.
      2. Confirm you see at least on failure (i.e. you can replicate)
      3. Apply the patch
      4. Run the script again and confirm all test run pass.

       

      Show
      For each branch: Run the attached testloop.sh file in the root of your moodle install, with an unpatched install. Confirm you see at least on failure (i.e. you can replicate) Apply the patch Run the script again and confirm all test run pass.  
    • Affected Branches:
      MOODLE_32_STABLE, MOODLE_33_STABLE, MOODLE_34_STABLE
    • Fixed Branches:
      MOODLE_32_STABLE, MOODLE_33_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-60243-master

      Description

      Discovered on nightlies.

      Caused by 437a07a5 added in -MDL-59994-. This line reuses a competency and introduces 2 user competencies with the same competency (and thus short name) which results in unpredictable ordering when running list_user_competencies_to_review(). Given this is supposed to test the user deletion, I see no problem just creating another competency first, and using that instead. 

        Attachments

          Issue Links

            Activity

              People

              Assignee:
              jaked Jake Dallimore
              Reporter:
              jaked Jake Dallimore
              Peer reviewer:
              Simey Lameze
              Integrator:
              Eloy Lafuente (stronk7)
              Tester:
              CiBoT
              Participants:
              Component watchers:
              Damyon Wiese, Jean-Philippe Gaudreau, Steve Massicotte, Serge Gauthier, Issam Taboubi, Adrian Greeve, Jake Dallimore, Mathew May, Mihail Geshoski, Peter Dias, Andrew Nicols, Jun Pataleta, Michael Hawkins, Shamim Rezaie, Simey Lameze
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Fix Release Date:
                13/Nov/17