Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-60250

Calendar popover misplaced in RTL languages

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 3.3.2, 3.4
    • Fix Version/s: 3.3.3
    • Component/s: Themes
    • Labels:
    • Testing Instructions:
      Hide
      1. Select the Clean theme.
      2. Ensure you have an RTL language pack installed.
      3. Navigate to the Frontpage.
      4. Ensure the 'Calendar' block is showing.
      5. Hover over the current date and confirm that the popover appears over the current date.
      6. Switch to an RTL language.
      7. Hover over the current date and confirm that the popover appears over the current date.
      Show
      Select the Clean theme. Ensure you have an RTL language pack installed. Navigate to the Frontpage. Ensure the 'Calendar' block is showing. Hover over the current date and confirm that the popover appears over the current date. Switch to an RTL language. Hover over the current date and confirm that the popover appears over the current date.
    • Affected Branches:
      MOODLE_33_STABLE, MOODLE_34_STABLE
    • Fixed Branches:
      MOODLE_33_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      wip_MDL-60250_master

      Description

      With reference to: https://moodle.org/mod/forum/discuss.php?d=359056 the Calendar (and I suspect all popover's) is misplaced in RTL languages.

      This is caused by the 'popover' class 'left' attribute being changed to 'right' by the auto-flipping technology in M3.3+.  The flip does not need to happen as its a screen position thing pertaining to where the originating popover is instigated and not to do with the flow of text.

      This only happens in BS2.3.2 based themes - i.e. that use Bootstrapbase as a parent.

        Attachments

        1. snapshot207.png
          snapshot207.png
          81 kB
        2. snapshot208.png
          snapshot208.png
          81 kB
        3. snapshot209.png
          snapshot209.png
          13 kB

          Issue Links

            Activity

              People

              Assignee:
              gb2048 Gareth J Barnard
              Reporter:
              gb2048 Gareth J Barnard
              Peer reviewer:
              Mihail Geshoski
              Integrator:
              David Monllaó
              Tester:
              Simey Lameze
              Participants:
              Component watchers:
              Bas Brands
              Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Fix Release Date:
                13/Nov/17