Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-60276

LTI Content Item: does not populate tool url when https

    XMLWordPrintable

    Details

    • Testing Instructions:
      Hide
      1. Deploy a new manually configured tool 
        1. URL https://lti.tools/test/tp.php 
        2. Content Item support is enabled by checking Content Item message (shown when clicking show more)
        3. Use secret for the secret
        4. Assign a unique key
      2. In a course, create an external link
        1. Select the LTI Test tool as the provider
        2. Click on Select Content
        3. Click content item
        4. Select Bespoke Item
          1. Type: LtiLinkItem
          2. Title: Testing MDL 60276
          3. Url: https://lti.tools/test/tp.php?explicit_url=true
          4. Return Selection
        5. Expected: toolUrl has https://lti.tools/test/tp.php?explicit_url=true, secureToolUrl is empty

       

      Show
      Deploy a new manually configured tool  URL  https://lti.tools/test/tp.php   Content Item support is enabled by checking Content Item message (shown when clicking show more) Use secret for the secret Assign a unique key In a course, create an external link Select the LTI Test tool as the provider Click on Select Content Click content item Select Bespoke Item Type: LtiLinkItem Title: Testing MDL 60276 Url: https://lti.tools/test/tp.php ?explicit_url=true Return Selection Expected: toolUrl has https://lti.tools/test/tp.php ?explicit_url=true, secureToolUrl is empty  
    • Affected Branches:
      MOODLE_32_STABLE, MOODLE_33_STABLE, MOODLE_34_STABLE
    • Fixed Branches:
      MOODLE_32_STABLE, MOODLE_33_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      master_MDL-60276

      Description

      Most of the LTI stack assumes the tool url as a primary URL and an optional secureToolUrl would the url differ in an https environment.

      The bug is content item is only populating the secureToolUrl when the url in the content item is https. Since only one url is handled in the content item processing, it should always be applied to the Tool URL.

       

        Attachments

          Activity

            People

            Assignee:
            claudevervoort Claude Vervoort
            Reporter:
            claudevervoort Claude Vervoort
            Peer reviewer:
            John Okely
            Integrator:
            Andrew Nicols
            Tester:
            Mark Nelson
            Participants:
            Component watchers:
            Adrian Greeve, Jake Dallimore, Mathew May, Mihail Geshoski, Peter Dias, Adrian Greeve, Jake Dallimore, Mathew May, Mihail Geshoski, Peter Dias
            Votes:
            2 Vote for this issue
            Watchers:
            5 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:
              Fix Release Date:
              13/Nov/17