Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-60277

Incorrect insights styling using binary targets

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Blocker
    • Resolution: Fixed
    • Affects Version/s: 3.4
    • Fix Version/s: 3.4
    • Component/s: Analytics
    • Labels:
    • Testing Instructions:
      Hide
      1. Using boost theme
      2. Download https://github.com/dmonllao/moodle-local_testanalytics/archive/abc03f0516bca563167eba80e6b884033b0eb118.zip extract in local/testanalytics and install the plugin
      3. Suspend one of your site users, your site should also have a user that is not suspended (you probably have admin already)
      4. Go to admin/tool/analytics/index.php and execute "Get predictions" action for "Undead users" model
      5. Now you should see a dropdown menu in "Undead users" model
      6. Select the suspended user from the dropdown, you SHOULD see "Undead" with a warning icon in "prediction" column; the cell color should be red
      7. Return to admin/tool/analytics/index.php and select a user that is not suspended from the dropdown, you SHOULD see "Alive" with a check icon in "prediction" column; the cell color should be green
      8. Switch to clean theme and verify that, even if the cells are not colored you can still see the warning icon for the suspended user and the check icon for the not suspended user
      Show
      Using boost theme Download https://github.com/dmonllao/moodle-local_testanalytics/archive/abc03f0516bca563167eba80e6b884033b0eb118.zip extract in local/testanalytics and install the plugin Suspend one of your site users, your site should also have a user that is not suspended (you probably have admin already) Go to admin/tool/analytics/index.php and execute "Get predictions" action for "Undead users" model Now you should see a dropdown menu in "Undead users" model Select the suspended user from the dropdown, you SHOULD see "Undead" with a warning icon in "prediction" column; the cell color should be red Return to admin/tool/analytics/index.php and select a user that is not suspended from the dropdown, you SHOULD see "Alive" with a check icon in "prediction" column; the cell color should be green Switch to clean theme and verify that, even if the cells are not colored you can still see the warning icon for the suspended user and the check icon for the not suspended user
    • Affected Branches:
      MOODLE_34_STABLE
    • Fixed Branches:
      MOODLE_34_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-60277_master

      Description

      This is a regression introduced by MDL-59265. Now mdl_analytics_predictions->prediction is a float so 0.0 is not an empty string anymore and binary::get_calculation_outcome, which has a if ($value) always returns OUTCOME_VERY_NEGATIVE.

        Attachments

        1. Screenshot_2017-10-04_11-53-00.png
          66 kB
          David Mudrák (@mudrd8mz)
        2. screenshot-1.png
          51 kB
          David Mudrák (@mudrd8mz)

          Issue Links

            Activity

              People

              • Votes:
                0 Vote for this issue
                Watchers:
                3 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  13/Nov/17