Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-60298

PHP 7.2 prepare behat extension for

    XMLWordPrintable

Details

    • MOODLE_34_STABLE
    • MOODLE_34_STABLE
    • Hide
      1. Delete any previous vendor dir.
      2. Verify that composer install runs ok:
        • Verify guzzle 6.3.0 is installed always (you should see a line like - Installing guzzlehttp/guzzle (6.3.0): Downloading (100%)
        • Cleaning vendor in between, with PHP 7.0, PHP 7.1 and PHP7.2
      3. Make sure you are still able to initialize the Behat and PHPUnit environment and execute the tests (no need to wait for the full run, nightly builds will cover that)
      4. Bonus (obviously not achievable right now, requires the rest of the Epic done): phpunit and behat pass completely with PHP 7.2.
      Show
      Delete any previous vendor dir. Verify that composer install runs ok: Verify guzzle 6.3.0 is installed always (you should see a line like - Installing guzzlehttp/guzzle (6.3.0): Downloading (100%) Cleaning vendor in between, with PHP 7.0, PHP 7.1 and PHP7.2 Make sure you are still able to initialize the Behat and PHPUnit environment and execute the tests (no need to wait for the full run, nightly builds will cover that) Bonus (obviously not achievable right now, requires the rest of the Epic done): phpunit and behat pass completely with PHP 7.2.

    Description

      From MDL-60279:

      Warning: count(): Parameter must be an array or an object that implements Countable in /.../vendor/guzzlehttp/guzzle/src/Handler/CurlFactory.php line 67

      was already fixed upstream, we just need to update requirements:
      https://github.com/guzzle/guzzle/commit/375c01b636cbbe967d4b180628abdf94c0b9070f

      So this is about:

      Attachments

        Issue Links

          Testing discovered

          Bug - A problem which impairs or prevents Moodle from functioning correctly. MDL-60411 PHP7.2 Cannot use 'object' as class name

          • Minor - Minor loss of function where workaround is possible
          • Closed

          Activity

            People

              stronk7 Eloy Lafuente (stronk7)
              stronk7 Eloy Lafuente (stronk7)
              Marina Glancy Marina Glancy
              Jun Pataleta Jun Pataleta
              David Mudrák (@mudrd8mz) David Mudrák (@mudrd8mz)
              Matteo Scaramuccia, David Woloszyn, Huong Nguyen, Jake Dallimore, Meirza, Michael Hawkins, Raquel Ortega, Safat Shahin, Stevani Andolo, David Woloszyn, Huong Nguyen, Jake Dallimore, Meirza, Michael Hawkins, Raquel Ortega, Safat Shahin, Stevani Andolo
              Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:
                13/Nov/17