Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-60306

rrule_manager_test is failing again! (Part 3)

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 3.2.5, 3.3.2
    • Fix Version/s: 3.2.6, 3.3.3
    • Component/s: Calendar
    • Labels:
    • Testing Instructions:
      Hide

      Note https://superuser.com/questions/983905/linux-date-command-not-working

      1. Set your PC's date to a month where it's the 2nd day of the month and the first Monday of the month as well. (e.g. 02-01-2017, 02-10-2017)
      2. Run the core_calendar_rrule_manager_testcase:

        vendor/bin/phpunit calendar/tests/rrule_manager_test.php
        

        • Confirm that everything passes.
      3. Set your PC's date to a month where the first Monday is after the 2nd day of the month. (e.g. 06-02-2017, 03-04-2017)
      4. Run the core_calendar_rrule_manager_testcase:

        vendor/bin/phpunit calendar/tests/rrule_manager_test.php
        

        • Confirm that everything passes.
      5. Set your PC's date to a month where the first Monday is before the 2nd day of the month. (e.g. 01-05-2017, 01-01-2018)
      6. Run the core_calendar_rrule_manager_testcase:

        vendor/bin/phpunit calendar/tests/rrule_manager_test.php
        

        • Confirm that everything passes.
      7. Make sure to set your system date back to how it was.
      Show
      Note https://superuser.com/questions/983905/linux-date-command-not-working Set your PC's date to a month where it's the 2nd day of the month and the first Monday of the month as well. (e.g. 02-01-2017, 02-10-2017) Run the core_calendar_rrule_manager_testcase: vendor/bin/phpunit calendar/tests/rrule_manager_test.php Confirm that everything passes. Set your PC's date to a month where the first Monday is after the 2nd day of the month. (e.g. 06-02-2017, 03-04-2017) Run the core_calendar_rrule_manager_testcase: vendor/bin/phpunit calendar/tests/rrule_manager_test.php Confirm that everything passes. Set your PC's date to a month where the first Monday is before the 2nd day of the month. (e.g. 01-05-2017, 01-01-2018) Run the core_calendar_rrule_manager_testcase: vendor/bin/phpunit calendar/tests/rrule_manager_test.php Confirm that everything passes. Make sure to set your system date back to how it was.
    • Affected Branches:
      MOODLE_32_STABLE, MOODLE_33_STABLE
    • Fixed Branches:
      MOODLE_32_STABLE, MOODLE_33_STABLE
    • Pull Master Branch:
      MDL-60306-master

      Description

      There was 1 failure:
       
      1) core_calendar_rrule_manager_testcase::test_monthly_events_with_byday_forever
      Failed asserting that two strings are equal.
      --- Expected
      +++ Actual
      @@ @@
      -'2018-10-01 09:00:00'
      +'2017-10-02 09:00:00'
       
      /var/www/html/moodle/calendar/tests/rrule_manager_test.php:883
      /var/www/html/moodle/lib/phpunit/classes/advanced_testcase.php:80
       
      To re-run:
       vendor/bin/phpunit core_calendar_rrule_manager_testcase calendar/tests/rrule_manager_test.php
      

        Attachments

        1. before-patch.png
          199 kB
          Jun Pataleta
        2. rruletest.sh
          2 kB
          Jun Pataleta

          Issue Links

            Activity

              People

              • Votes:
                2 Vote for this issue
                Watchers:
                10 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  13/Nov/17