Loading...

XML

Word

Printable

Type: Bug
Resolution: Fixed
Priority: Critical
Fix Version/s: 3.3.3
Affects Version/s: 3.3.1, 3.4
Component/s: Files API, Portfolio, Tasks
Labels:
- ci
- triaged

Affected Branches:
MOODLE_33_STABLE, MOODLE_34_STABLE
Fixed Branches:
MOODLE_33_STABLE
Pull from Repository:
https://github.com/scara/moodle
Pull Main Branch:
m34_~~MDL-60318~~_Undefined_method_file_storage-move_to_trash
Pull Main Diff URL:
https://github.com/scara/moodle/commit/5ca85a1efe7fcab9c989567169506ee4829c2e89
Testing Instructions:
Hide

(difficulty: hard, requires changes to the mainstream code)

The unit tests cannot cover the test case but should be used to check for regressions: vendor/bin/phpunit core_files_file_storage_testcase lib/filestorage/tests/file_storage_test.php

To go further w/ the coverage a new line to throw an exception should be added into the mainstream just before these lines:

https://github.com/scara/moodle/commit/5ca85a1efe7fcab9c989567169506ee4829c2e89#diff-6c0a8861eef371f78dde4be1467a8a1fR1326

https://github.com/scara/moodle/commit/5ca85a1efe7fcab9c989567169506ee4829c2e89#diff-6c0a8861eef371f78dde4be1467a8a1fR1445

https://github.com/scara/moodle/commit/5ca85a1efe7fcab9c989567169506ee4829c2e89#diff-6c0a8861eef371f78dde4be1467a8a1fR1604
in order to enter in the catch() block.
The expected result will be a stored_file_creation_exception exception when the three functions affected by the bug will be called and not a fatal error about an undefined method.
Show
(difficulty: hard, requires changes to the mainstream code) The unit tests cannot cover the test case but should be used to check for regressions: vendor/bin/phpunit core_files_file_storage_testcase lib/filestorage/tests/file_storage_test.php To go further w/ the coverage a new line to throw an exception should be added into the mainstream just before these lines: https://github.com/scara/moodle/commit/5ca85a1efe7fcab9c989567169506ee4829c2e89#diff-6c0a8861eef371f78dde4be1467a8a1fR1326 https://github.com/scara/moodle/commit/5ca85a1efe7fcab9c989567169506ee4829c2e89#diff-6c0a8861eef371f78dde4be1467a8a1fR1445 https://github.com/scara/moodle/commit/5ca85a1efe7fcab9c989567169506ee4829c2e89#diff-6c0a8861eef371f78dde4be1467a8a1fR1604 in order to enter in the catch() block. The expected result will be a stored_file_creation_exception exception when the three functions affected by the bug will be called and not a fatal error about an undefined method .

When executing the scheduled task core\task\portfolio_cron_task sometimes we get the following error in the cron log: PHP Fatal error: Call to undefined method file_storage::move_to_trash() in /moodle/lib/filestorage/file_storage.php on line 1427

We got this error after the upgrade to 3.3.1 version. The cron was blocked and our workaround was disabling the scheduled task and enable it one day after the problem.

After looking at the code we found that the function move_to_trash() doesn't exist. The change was added in this commit: https://git.moodle.org/gw?p=moodle.git;a=commitdiff;h=16a34ae1892014a6ca3055a95ac7310442529a6c

is a regression caused by

MDL-46375 Move file-system specific components of file_storage and stored_file to new overridable API

Closed

Assignee:: Matteo Scaramuccia

Reporter:: Paula Ardanza Menendez

Peer reviewer:: Ankit Agarwal

Integrator:: Eloy Lafuente (stronk7)

Tester:: Marina Glancy

Participants:: Andrew Lyons, Ankit Agarwal, CiBoT, Eloy Lafuente (stronk7), Marina Glancy, Matteo Scaramuccia, Paula Ardanza Menendez

Votes:: 2 Vote for this issue

Watchers:: 6 Start watching this issue

Created:: 03/Oct/17 11:16 AM

Updated:: 14/Oct/17 3:09 AM

Resolved:: 14/Oct/17 3:09 AM

Details

Description

Attachments

Issue Links

Activity

People

Dates

Clockify