[MDL-60366] Feedback upgrade deletes valid multiple attempts - Moodle Tracker

XML

Word

Printable

Details

Type: Bug
Status: Closed
Priority: Critical
Resolution: Fixed
Affects Version/s: 3.1.8, 3.2.5, 3.3.2
Fix Version/s: 3.1.9, 3.2.6, 3.3.3
Component/s: Feedback
Labels:
- ci
- data-loss
- partner
- patch
- release_notes
- synergy-learning

Affected Branches:
MOODLE_31_STABLE, MOODLE_32_STABLE, MOODLE_33_STABLE
Fixed Branches:
MOODLE_31_STABLE, MOODLE_32_STABLE, MOODLE_33_STABLE
Pull from Repository:
git://github.com/davosmith/moodle.git
Pull Master Branch:
~~MDL-60366~~_feedback_upgrade
Pull Master Diff URL:
https://github.com/davosmith/moodle/compare/moodle:master...MDL-60366_feedback_upgrade
Testing Instructions:
Hide

Follow the testing instructions on ~~MDL-58227~~ to check that this does not break that upgrade (you will probably need to start with a Moodle 3.0 site for it to work).

In addition, you need to do the following steps, before you run the upgrade:

Create a feedback with 'anonymous' responses and multiple feedback allowed

Answer the feedback multiple times as the same user (and possibly as a few different users as well, for good measure)

Confirm that each anonymous attempt can be viewed separately

After the upgrade has run:

Check that each of the anonymous responses can still be viewed separately (but that the non-anonymous responses have had their duplicates removed)
Show
Follow the testing instructions on MDL-58227 to check that this does not break that upgrade (you will probably need to start with a Moodle 3.0 site for it to work). In addition, you need to do the following steps, before you run the upgrade: Create a feedback with 'anonymous' responses and multiple feedback allowed Answer the feedback multiple times as the same user (and possibly as a few different users as well, for good measure) Confirm that each anonymous attempt can be viewed separately After the upgrade has run: Check that each of the anonymous responses can still be viewed separately (but that the non-anonymous responses have had their duplicates removed)

Description

The feedback upgrade in ~~MDL-58227~~ is overzealous in deleting 'duplicate' attempts.

If a feedback is set to 'anonymous' and multiple attempts are allowed, then it is completely valid for a single user to have more than one attempt and for those attempts to be displayed separately.

This upgrade step has caused a fairly large loss of data for one of our customers (who was using a anonymous feedback instances as an issue tracking system).

Attachments

Issue Links

has a non-specific relationship to

MDL-60592 Restore feedback responses deleted in upgrade script in March 2017 (Moodle 3.1.6, 3.2.3)

Closed

is a regression caused by

MDL-58227 New feedback attempts create new entries in feedback_completed (instead resetting the last attempt)

Closed

Testing discovered

MDL-60578 Feedback web services incorrectly treat courseid

Closed

Activity

People

Assignee:: Davo Smith

Reporter:: Davo Smith

Peer reviewer:: David Monllaó

Integrator:: Damyon Wiese

Tester:: Mark Nelson

Participants:: CiBoT, Damyon Wiese, David Monllaó, Davo Smith, Juan Leyva, Marina Glancy, Mark Nelson

Component watchers:: Amaia Anabitarte, Carlos Escobedo, Laurent David, Sabina Abellan, Sara Arjona (@sarjona)

Votes:: 0 Vote for this issue

Watchers:: 6 Start watching this issue

Dates

Created:: 07/Oct/17 3:33 AM

Updated:: 28/Oct/17 6:45 AM

Resolved:: 28/Oct/17 6:45 AM

Fix Release Date:: 13/Nov/17