Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-60366

Feedback upgrade deletes valid multiple attempts

    XMLWordPrintable

    Details

    • Testing Instructions:
      Hide

      Follow the testing instructions on MDL-58227 to check that this does not break that upgrade (you will probably need to start with a Moodle 3.0 site for it to work).

      In addition, you need to do the following steps, before you run the upgrade:

      • Create a feedback with 'anonymous' responses and multiple feedback allowed
      • Answer the feedback multiple times as the same user (and possibly as a few different users as well, for good measure)
      • Confirm that each anonymous attempt can be viewed separately

      After the upgrade has run:

      • Check that each of the anonymous responses can still be viewed separately (but that the non-anonymous responses have had their duplicates removed)
      Show
      Follow the testing instructions on MDL-58227 to check that this does not break that upgrade (you will probably need to start with a Moodle 3.0 site for it to work). In addition, you need to do the following steps, before you run the upgrade: Create a feedback with 'anonymous' responses and multiple feedback allowed Answer the feedback multiple times as the same user (and possibly as a few different users as well, for good measure) Confirm that each anonymous attempt can be viewed separately After the upgrade has run: Check that each of the anonymous responses can still be viewed separately (but that the non-anonymous responses have had their duplicates removed)
    • Affected Branches:
      MOODLE_31_STABLE, MOODLE_32_STABLE, MOODLE_33_STABLE
    • Fixed Branches:
      MOODLE_31_STABLE, MOODLE_32_STABLE, MOODLE_33_STABLE
    • Pull 3.1 Branch:
      MDL-60366_feedback_upgrade_31
    • Pull Master Branch:
      MDL-60366_feedback_upgrade

      Description

      The feedback upgrade in MDL-58227 is overzealous in deleting 'duplicate' attempts.

      If a feedback is set to 'anonymous' and multiple attempts are allowed, then it is completely valid for a single user to have more than one attempt and for those attempts to be displayed separately.

      This upgrade step has caused a fairly large loss of data for one of our customers (who was using a anonymous feedback instances as an issue tracking system).

        Attachments

          Issue Links

            Activity

              People

              • Votes:
                0 Vote for this issue
                Watchers:
                6 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  13/Nov/17