Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-60384

Improve link title for add new chapter link

    XMLWordPrintable

    Details

    • Testing Instructions:
      Hide

      Testing Instructions

      1. Login as admin/teacher
      2. Go to any course in edit mode
      3. Create book if none exists
        1. Create a chapter with the title "New chapter 1"
      4. In the table of contents, hover over '+'  and confirm the title 'Add new chapter after New chapter 1' appears
      5. Click '+'
      6. Confirm a label named 'Previous chapter' with a value "New chapter 1" exists
      7. Save the new chapter as "New chapter 2"
      8. In the table of contents, edit the newly created chapter(i.e. 'New chapter 2')
      9. Confirm a label named 'Previous chapter' with a label "New chapter 1" exists
      Show
      Testing Instructions Login as admin/teacher Go to any course in edit mode Create book if none exists Create a chapter with the title "New chapter 1" In the table of contents, hover over '+'  and confirm  the title 'Add new chapter after New chapter 1' appears Click '+' Confirm a label named 'Previous chapter' with a value "New chapter 1" exists Save the new chapter as "New chapter 2" In the table of contents, edit the newly created chapter(i.e. 'New chapter 2') Confirm a label named 'Previous chapter' with a label "New chapter 1" exists
    • Affected Branches:
      MOODLE_34_STABLE, MOODLE_35_STABLE, MOODLE_36_STABLE
    • Fixed Branches:
      MOODLE_37_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-60384-master

      Description

      At the moment, the action title for adding a new chapter is "Add new chapter", but it doesn't say where to.

      We should consider changing this to something more like:

      Add a new chapter after chapter 1

      This will also help improve some of the existing behat tests, e.g.

      -    And I click on "a[href*='pagenum=1']" "css_element"
      +    And I click on "Add a new chapter after chapter 1" "link"
      

        Attachments

        1. screenshot-1.png
          screenshot-1.png
          65 kB
        2. Screenshot from 2018-09-27 11-52-07.png
          Screenshot from 2018-09-27 11-52-07.png
          13 kB
        3. toc_dom.png
          toc_dom.png
          130 kB
        4. toc.png
          toc.png
          24 kB

          Issue Links

            Activity

              People

              Assignee:
              peterdias Peter Dias
              Reporter:
              dobedobedoh Andrew Nicols
              Peer reviewer:
              Adrian Greeve
              Integrator:
              Sara Arjona (@sarjona)
              Tester:
              Janelle Barcega
              Participants:
              Component watchers:
              Adrian Greeve, Jake Dallimore, Mathew May, Mihail Geshoski, Peter Dias, Andrew Nicols, Jun Pataleta, Michael Hawkins, Shamim Rezaie, Simey Lameze, David Jones, Adrian Greeve, Jake Dallimore, Mathew May, Mihail Geshoski, Peter Dias
              Votes:
              0 Vote for this issue
              Watchers:
              6 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Fix Release Date:
                20/May/19

                  Time Tracking

                  Estimated:
                  Original Estimate - 0 minutes
                  0m
                  Remaining:
                  Remaining Estimate - 0 minutes
                  0m
                  Logged:
                  Time Spent - 16 minutes
                  16m