Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-60396

WS mod_workshop_evaluate_submission does not validate max grade limit

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 3.4
    • Fix Version/s: 3.4
    • Component/s: Web Services, Workshop
    • Labels:
      None
    • Testing Instructions:
      Hide

      Get unit tests passing should be enough. No manual testing needed.

      Show
      Get unit tests passing should be enough. No manual testing needed.
    • Affected Branches:
      MOODLE_34_STABLE
    • Fixed Branches:
      MOODLE_34_STABLE

      Description

      This is a followup of MDL-60144 where the mod_workshop_evaluate_submission external was implemented and a post-fix was completely missed.

      The fix is about to ensure that the function does validate the grade is not bigger than the maxgrade allowed.

      Link to the missed commit that is going to be integrated here:

      https://tracker.moodle.org/browse/MDL-60144?focusedCommentId=481529&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-481529

      (will amend commit message to point here)

      Sorry for the trouble!

      Eloy Lafuente (stronk7).

        Attachments

          Activity

            People

            • Assignee:
              jleyva Juan Leyva
              Reporter:
              stronk7 Eloy Lafuente (stronk7)
              Integrator:
              Eloy Lafuente (stronk7)
              Tester:
              CiBoT
              Participants:
              Component watchers:
              Juan Leyva, Jake Dallimore, Jun Pataleta, Ryan Wyllie, Amaia Anabitarte, Carlos Escobedo, Sara Arjona (@sarjona), Víctor Déniz Falcón
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:
                Fix Release Date:
                13/Nov/17