Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-60398

Unable to download resource of type "Folder" with name of 200+ bytes

    XMLWordPrintable

    Details

    • Testing Instructions:
      Hide
      1. Log in as Admin
      2. Create a Course.
      3. Create a Folder resource into the Course.
        • add a long name:

          ANDREW IS HERE: abcdefghijklmnopqrstuvwxyz1234567890!@#$%^&*()-=_+XABCDEFGHIJKLMNOPQRSTUVWXYZ1234567890!@#$%^&*()-=_+Xabcdefghijklmnopqrstuvwxyz1234567890!@#$%^&*()-=_+XABCDEFGHIJKLMNOPQRSTUVWXYZ1234567890!@#$%^&*()-=_+
          

        • upload at least one file to the Folder.
        • Click "Save and display".
      4. In the Folder resource, click "Download folder".
        • Make sure errors are NOT displayed and the folder is downloading.
        • Make sure the name of the downloaded zip contains an extract of the Folder's name (50 characters).
      Show
      Log in as Admin Create a Course. Create a Folder resource into the Course. add a long name : ANDREW IS HERE: abcdefghijklmnopqrstuvwxyz1234567890!@#$%^&*()-=_+XABCDEFGHIJKLMNOPQRSTUVWXYZ1234567890!@#$%^&*()-=_+Xabcdefghijklmnopqrstuvwxyz1234567890!@#$%^&*()-=_+XABCDEFGHIJKLMNOPQRSTUVWXYZ1234567890!@#$%^&*()-=_+ upload at least one file to the Folder. Click "Save and display". In the Folder resource, click "Download folder". Make sure errors are NOT displayed and the folder is downloading. Make sure the name of the downloaded zip contains an extract of the Folder's name (50 characters).
    • Affected Branches:
      MOODLE_33_STABLE
    • Fixed Branches:
      MOODLE_33_STABLE, MOODLE_34_STABLE
    • Pull Master Branch:
      MDL-60398-master

      Description

      It not possible to download resource "Folder" (as zip) with name consisting of more than 199 bytes (not chars)

      Steps to reproduce:

      1. Go to course and create resource of type "Folder" folder in course with name of 200 or more ASCII chars
      2. Add any files
      3. Ensure that chechkbox "Show Download Folder" is checked
      4. Save and return to course
      5. Click on folder to open it
      6. Click on Download button

      Result: error "unable to download folder"

      For example it is not possible to download folder with name consisting of 200 ASCII chars. The number of chars will be less If you use international chars that are multibyte, for example, Russian (2 bytes per char).

      At the same time there is no any restriction on folder name length neither in doc nor in folder properties.

      Version: 3.3.2+ (Build 20170915)

       

       

        Attachments

          Issue Links

            Activity

              People

              • Votes:
                0 Vote for this issue
                Watchers:
                12 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  19/Mar/18

                  Time Tracking

                  Estimated:
                  Original Estimate - 0 minutes
                  0m
                  Remaining:
                  Remaining Estimate - 0 minutes
                  0m
                  Logged:
                  Time Spent - 30 minutes
                  30m