[MDL-60406] Calendar problematic time calculations - Moodle Tracker

XML

Word

Printable

Details

Type: Bug
Status: Closed
Priority: Blocker
Resolution: Fixed
Affects Version/s: 3.4
Fix Version/s: 3.4
Component/s: Calendar
Labels:
- ci
- triaged

Affected Branches:
MOODLE_34_STABLE
Fixed Branches:
MOODLE_34_STABLE
Epic Link:
Calendar Improvements
Pull from Repository:
git://github.com/lameze/moodle.git
Pull Master Branch:
~~MDL-60406~~-master
Pull Master Diff URL:
https://github.com/lameze/moodle/compare/9644c0e...MDL-60406-master
Testing Instructions:
Hide

Log in as admin and go to calendar

Add few events: one day ago, today, tomorrow and few days ahead.

Add another event in the very first day of the next month.

On the calendar month view make sure all events displayed belongs to the month you are viewing and the event you created on the first day of the next month is not displayed.

Click on the number representing the day (today) to go to day view

Make sure all events displayed belongs to that day, and tomorrow events are not displayed.

Using the day navigation link (Thursday ►), switch to next day.

Make sure the events displayed belongs to the day you are viewing.

Go back to days ago using the day navigation link (◄ Tuesday)

Make sure the events displayed belongs to the day you are viewing.

On the user menu, click on Preferences.

Click Calendar preferences

On your calendar preferences, set Upcoming events look-ahead to 1 and save.

Now, go back to site home.

Turn editing on and add upcoming block

Make sure it display only today's events.

Go back to calendar preferences and change that setting to 2.

Go back to site home and make sure the upcoming events just display events from today, tomorrow.
Show
Log in as admin and go to calendar Add few events: one day ago, today, tomorrow and few days ahead. Add another event in the very first day of the next month. On the calendar month view make sure all events displayed belongs to the month you are viewing and the event you created on the first day of the next month is not displayed. Click on the number representing the day (today) to go to day view Make sure all events displayed belongs to that day, and tomorrow events are not displayed. Using the day navigation link (Thursday ►), switch to next day. Make sure the events displayed belongs to the day you are viewing. Go back to days ago using the day navigation link (◄ Tuesday) Make sure the events displayed belongs to the day you are viewing. On the user menu, click on Preferences . Click Calendar preferences On your calendar preferences, set Upcoming events look-ahead to 1 and save. Now, go back to site home. Turn editing on and add upcoming block Make sure it display only today's events. Go back to calendar preferences and change that setting to 2. Go back to site home and make sure the upcoming events just display events from today, tomorrow.

Description

We just noticed the calendar_get_view() is calculating dates using DAYSECS and HOURSECS for day, month and upcoming views. That can be a problem, specially for daylight savings, returning the wrong time.

We need to review calendar_get_view() and maybe other places using those constants and change them to use our Time API.

https://docs.moodle.org/dev/Time_API

Attachments

Issue Links

Discovered while testing

MDL-60092 Update upcoming block

Closed

will help resolve

MDL-48591 Mini Calendar Missing "Last Hour of DST Month" Events

Closed

Activity

People

Assignee:: Simey Lameze

Reporter:: Simey Lameze

Peer reviewer:: Mihail Geshoski

Integrator:: David Monllaó

Tester:: Adrian Greeve

Participants:: Adrian Greeve, CiBoT, David Monllaó, Mihail Geshoski, Simey Lameze

Component watchers:: Andrew Lyons, Huong Nguyen, Jun Pataleta, Michael Hawkins, Shamim Rezaie, Simey Lameze

Votes:: 0 Vote for this issue

Watchers:: 3 Start watching this issue

Dates

Created:: 11/Oct/17 8:43 PM

Updated:: 12/Feb/19 2:42 AM

Resolved:: 21/Oct/17 3:36 PM

Fix Release Date:: 13/Nov/17