Details
-
Type:
Bug
-
Status: Closed
-
Priority:
Minor
-
Resolution: Fixed
-
Affects Version/s: 3.4, 3.6.4
-
Component/s: Analytics
-
Testing Instructions:
-
Affected Branches:MOODLE_34_STABLE, MOODLE_36_STABLE
-
Fixed Branches:MOODLE_36_STABLE, MOODLE_37_STABLE
-
Pull from Repository:
-
Pull Master Branch:
MDL-60407-master -
Pull Master Diff URL:
Description
Predictions can be hidden by selecting "Not useful" or "Acknowledged". When the last prediction in the page is hidden by the user we redirect the user to the previous page where he was (referrer if it exists and reload the page as fallback) This results to not be ideal in the following scenario:
- I get 3 predictions
- I click "View prediction details" for one of them
- I view the prediction details and I say, ok, this is fine, and I select "Actions > Acknowledged"
- I am redirected to the insights page where I now see 2 predictions
- I flag them both as "Not useful"; but when I flag the second one I am redirected to the prediction details of the first prediction I've hide
Instead of redirecting users using the referrer we should redirect the user to admin/tool/analytics/index.php (or just a reload, because this is also used by teachers without managing access) if we are in the insights list page or to the insights page if we are viewing the details of a prediction.