Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-60407

Insights report redirection after hiding the last prediction does not always result in the best user experience

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 3.4, 3.6.4
    • Fix Version/s: 3.6.5, 3.7.1
    • Component/s: Analytics
    • Labels:
    • Testing Instructions:
      Hide
      1. Go to Site admin > Analytics > Analytics settings and untick onlycli setting.
      2. Create two courses C1 and C2.
      3. Go to Site admin > Analytics > Analytics models.
      4. If No teaching model is disabled, click on Actions > Enable for No teaching model.
      5. Click on Actions > Get predictions for No teaching model.
      6. Confirm in the Get predictions page you get green notifications under Training results and Prediction results.
      7. Click Continue.
      8. In the Insights column of the No teaching model, select All predictions.
      9. Confirm that in the Insights report for the No teaching model there are two predictions.
      10. In the first predictions, select Actions > View details.
      11. In the prediction details page, select Actions > Acknowledged.
      12. Confirm that you are redirected to the Insights report page and there is only one prediction left.
      13. Select Actions > Not useful for that prediction.
      14. Confirm that you are still on the Insights report page and the "No insights reported" notification is displayed.
      Show
      Go to Site admin > Analytics > Analytics settings and untick onlycli setting. Create two courses C1 and C2. Go to Site admin > Analytics > Analytics models . If No teaching model is disabled, click on Actions > Enable for No teaching model. Click on Actions > Get predictions for No teaching model. Confirm in the Get predictions page you get green notifications under Training results and Prediction results . Click Continue. In the Insights column of the No teaching model , select All predictions . Confirm that in the Insights report for the No teaching model there are two predictions. In the first predictions, select Actions > View details. In the prediction details page, select Actions > Acknowledged . Confirm that you are redirected to the Insights report page and there is only one prediction left. Select Actions > Not useful for that prediction. Confirm that you are still on the Insights report page and the "No insights reported" notification is displayed.
    • Affected Branches:
      MOODLE_34_STABLE, MOODLE_36_STABLE
    • Fixed Branches:
      MOODLE_36_STABLE, MOODLE_37_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-60407-master
    • Pull Master Diff URL:

      Description

      Predictions can be hidden by selecting "Not useful" or "Acknowledged". When the last prediction in the page is hidden by the user we redirect the user to the previous page where he was (referrer if it exists and reload the page as fallback) This results to not be ideal in the following scenario:

      1. I get 3 predictions
      2. I click "View prediction details" for one of them
      3. I view the prediction details and I say, ok, this is fine, and I select "Actions > Acknowledged"
      4. I am redirected to the insights page where I now see 2 predictions
      5. I flag them both as "Not useful"; but when I flag the second one I am redirected to the prediction details of the first prediction I've hide

      Instead of redirecting users using the referrer we should redirect the user to admin/tool/analytics/index.php (or just a reload, because this is also used by teachers without managing access) if we are in the insights list page or to the insights page if we are viewing the details of a prediction.

        Attachments

          Activity

            People

            Assignee:
            vmdef Víctor Déniz Falcón
            Reporter:
            dmonllao David Monllaó
            Peer reviewer:
            David Monllaó
            Integrator:
            Jun Pataleta
            Tester:
            Janelle Barcega
            Participants:
            Component watchers:
            Elizabeth Dalton, Amaia Anabitarte, Carlos Escobedo, Ferran Recio, Ilya Tregubov, Sara Arjona (@sarjona)
            Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:
              Fix Release Date:
              8/Jul/19

                Time Tracking

                Estimated:
                Original Estimate - 0 minutes
                0m
                Remaining:
                Remaining Estimate - 0 minutes
                0m
                Logged:
                Time Spent - 6 hours, 10 minutes
                6h 10m