Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-60415

launch.php shows error messages when LTI custom parameters are used

    XMLWordPrintable

    Details

    • Testing Instructions:
      Hide

      Testing instruction:

      • Add an ‘External Tool’ activity to the new course and configure it:
        • Use an arbitrary Tool-URL (does not have to exist)
        • Add any custom parameter (e.g., “mypar=$User.id" or "mygroups=$Moodle.Person.userGroupIds”) to the custom parameters field (you might have to unfold the form to see the custom parameters field)
        • Save and return to the course
      • Click the ‘External Tool’ activity and capture the network traffic of your browser.
      • The “launch.php?.. “ should no longer contain the error-messages (They were placed at the top of the page over the “ltiLaunchForm”)

        • Notice: Trying to get property of non-object in /home/ankit/moodles/integration_master/moodle/mod/lti/locallib.php on line 1134
          Notice: Trying to get property of non-object in /home/ankit/moodles/integration_master/moodle/mod/lti/locallib.php on line 1134

      Show
      Testing instruction: Add an ‘External Tool’ activity to the new course and configure it: Use an arbitrary Tool-URL (does not have to exist) Add any custom parameter (e.g., “mypar=$User.id" or "mygroups=$Moodle.Person.userGroupIds”) to the custom parameters field (you might have to unfold the form to see the custom parameters field) Save and return to the course Click the ‘External Tool’ activity and capture the network traffic of your browser. The “launch.php?.. “ should no longer contain the error-messages (They were placed at the top of the page over the “ltiLaunchForm”) Notice: Trying to get property of non-object in /home/ankit/moodles/integration_master/moodle/mod/lti/locallib.php on line 1134 Notice: Trying to get property of non-object in /home/ankit/moodles/integration_master/moodle/mod/lti/locallib.php on line 1134
    • Affected Branches:
      MOODLE_33_STABLE, MOODLE_34_STABLE
    • Fixed Branches:
      MOODLE_33_STABLE, MOODLE_34_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      wip-MDL-60415-master
    • Pull Master Diff URL:

      Description

      When LTI custom parameters are used, the launch.php shows the following error message before redirecting to the page of the tool provider:

      Notice: Trying to get property of non-object in /home/ankit/moodles/integration_master/moodle/mod/lti/locallib.php on line 1134
      Notice: Trying to get property of non-object in /home/ankit/moodles/integration_master/moodle/mod/lti/locallib.php on line 1134

        Attachments

          Issue Links

          Discovered while testing

          Improvement - An enhancement to an existing Moodle feature. MDL-55358 LIS Group Variables support in LTI

          • Minor - Minor loss of function where workaround is possible
          • Closed

            Activity

              People

              Assignee:
              davidknu David Knuplesch
              Reporter:
              davidknu David Knuplesch
              Peer reviewer:
              Adrian Greeve Adrian Greeve
              Integrator:
              Andrew Lyons Andrew Lyons
              Tester:
              David Mudrák (@mudrd8mz) David Mudrák (@mudrd8mz)
              Participants:
              Component watchers:
              Adrian Greeve, Jake Dallimore, Mathew May, Mihail Geshoski, Peter Dias, Sujith Haridasan
              Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Fix Release Date:
                15/Jan/18