Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-60427

Drag and Drop onto Course Page: UX improvement for unsupported resources

    XMLWordPrintable

    Details

    • Testing Instructions:
      Hide

      Test using chrome, firefox and internet explorer. (Note: IE11 behaviour is to not upload anything if a folder is included - see comment below for details)

      I've attached a zip file containing some sample files I've used for testing - upload test.zip (it is worth testing with files smaller than 10k and larger than 10k).

      • Create a course and visit it
      • Turn editing mode on
      • Try dragging and dropping the following combinations of files and directories from your computer desktop directory to your course:
        • A single file
        • Multiple files
        • A single folder
        • Multiple folders
        • A mix of files and folders
      • In each case, files should upload as normal, folders should show an error popup "Unable to read the file '[filename]' - please check this really is a file and not a folder" and the spinner/placeholder for the folder upload should be removed
      Show
      Test using chrome, firefox and internet explorer. ( Note: IE11 behaviour is to not upload anything if a folder is included - see comment below for details ) I've attached a zip file containing some sample files I've used for testing - upload test.zip (it is worth testing with files smaller than 10k and larger than 10k). Create a course and visit it Turn editing mode on Try dragging and dropping the following combinations of files and directories from your computer desktop directory to your course: A single file Multiple files A single folder Multiple folders A mix of files and folders In each case, files should upload as normal, folders should show an error popup "Unable to read the file ' [filename] ' - please check this really is a file and not a folder" and the spinner/placeholder for the folder upload should be removed
    • Affected Branches:
      MOODLE_34_STABLE
    • Fixed Branches:
      MOODLE_35_STABLE
    • Pull Master Branch:
      MDL-60427_dnd_folder_improved

      Description

      Hi,
      we've encountered that if a user tries to upload a resource that is not supported by the dragging and dropping onto course page feature, there's an alert saying that there was an error whilst communicating with the server.
      In the background the resource seems to be adding to the course, but it has an infinite spinner in front of its title:

      Only with a page refresh the unsupported entry will disappear on the course page.
      A resouce that triggers this behavior is a simple folder from your computer dragged onto the course page. We don't know if there are many more of such unsupported resources.

      Improvement proposal

      • Description text has to be more explaining for the user. For example:
        "The resource [name] you are trying to upload to the course is not supported by drag and drop."
      • This resource should not appear on the course page in the background
        Just like it is solved with resources that are too large for the course:

      Steps to reproduce

      Preconditions:

      • Existing Moodle instance
      • Existing course
      • At least one teacher or manager is enrolled
      • A folder on your computer

      Steps:

      1. Login with the user account
      2. Go to the course
      3. Turn editing on
      4. Drag and drop the folder from your computer onto the course page
        => See that an alert with the text "An error occurred whilst communicating with the server" is popping up and the the folder seems to be added to the course page displaying an infinite spinner in front of the folder title.

      Best, Kathrin

        Attachments

        1. MDL-60427.zip
          2.09 MB
        2. MDL-60427 OSX_Safari test folder 1.png
          MDL-60427 OSX_Safari test folder 1.png
          74 kB
        3. MDL-60427 OSX_Safari test folder 2.png
          MDL-60427 OSX_Safari test folder 2.png
          63 kB
        4. resource_too_large.png
          resource_too_large.png
          14 kB
        5. unsupported_dnd.png
          unsupported_dnd.png
          24 kB
        6. Untitled.png
          Untitled.png
          344 kB
        7. upload test.zip
          10 kB

          Activity

            People

            • Votes:
              1 Vote for this issue
              Watchers:
              9 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:
                Fix Release Date:
                17/May/18