Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-60459

Not including 'visibleoncoursepage' in module info causes error in update_moduleinfo

    XMLWordPrintable

Details

    • Bug
    • Resolution: Fixed
    • Minor
    • 3.5.5, 3.6.3
    • 3.3, 3.7
    • Course
    • MOODLE_33_STABLE, MOODLE_37_STABLE
    • MOODLE_35_STABLE, MOODLE_36_STABLE
    • MDL-60459_master
    • Hide
      Test 1 - Regression test.
      1. Edit the file lib/testing/generator/module_generator.php and in prepare_moduleinfo_record and remove the line 'visibleoncoursepage' => 1.
      2. Run the unit tests in mod/book/tests/lib_test.php.
      3. Confirm there are no errors.
      Test 2
      1. Edit the file course/modlib.php and add unset($moduleinfo->visibleoncoursepage) to the start of the function update_moduleinfo.
      2. Visit a course.
      3. Add a book.
      4. Edit the book.
      5. Save changes.
      6. Confirm there are no errors.
      Show
      Test 1 - Regression test. Edit the file lib/testing/generator/module_generator.php and in prepare_moduleinfo_record and remove the line 'visibleoncoursepage' => 1 . Run the unit tests in mod/book/tests/lib_test.php . Confirm there are no errors. Test 2 Edit the file course/modlib.php and add unset($moduleinfo->visibleoncoursepage) to the start of the function update_moduleinfo . Visit a course. Add a book. Edit the book. Save changes. Confirm there are no errors.

    Description

      Similar to MDL-59655 but is a bug in the update_moduleinfo function.

      Attachments

        Issue Links

          Activity

            People

              kepeter Peter Eliyahu Kornfeld
              markn Mark Nelson
              Mark Nelson Mark Nelson
              Adrian Greeve Adrian Greeve
              Elizabeth Dalton Elizabeth Dalton
              Votes:
              2 Vote for this issue
              Watchers:
              5 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Clockify

                  Error rendering 'clockify-timesheets-time-tracking-reports:timer-sidebar'. Please contact your Jira administrators.