Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-60459

Not including 'visibleoncoursepage' in module info causes error in update_moduleinfo

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 3.3, 3.7
    • Fix Version/s: 3.5.5, 3.6.3
    • Component/s: Course
    • Labels:
    • Testing Instructions:
      Hide
      Test 1 - Regression test.
      1. Edit the file lib/testing/generator/module_generator.php and in prepare_moduleinfo_record and remove the line 'visibleoncoursepage' => 1.
      2. Run the unit tests in mod/book/tests/lib_test.php.
      3. Confirm there are no errors.
      Test 2
      1. Edit the file course/modlib.php and add unset($moduleinfo->visibleoncoursepage) to the start of the function update_moduleinfo.
      2. Visit a course.
      3. Add a book.
      4. Edit the book.
      5. Save changes.
      6. Confirm there are no errors.
      Show
      Test 1 - Regression test. Edit the file lib/testing/generator/module_generator.php and in prepare_moduleinfo_record and remove the line 'visibleoncoursepage' => 1 . Run the unit tests in mod/book/tests/lib_test.php . Confirm there are no errors. Test 2 Edit the file course/modlib.php and add unset($moduleinfo->visibleoncoursepage) to the start of the function update_moduleinfo . Visit a course. Add a book. Edit the book. Save changes. Confirm there are no errors.
    • Affected Branches:
      MOODLE_33_STABLE, MOODLE_37_STABLE
    • Fixed Branches:
      MOODLE_35_STABLE, MOODLE_36_STABLE
    • Pull from Repository:
    • Pull 3.5 Branch:
    • Pull Master Branch:
      MDL-60459_master

      Description

      Similar to MDL-59655 but is a bug in the update_moduleinfo function.

        Attachments

          Issue Links

            Activity

              People

              Assignee:
              kepeter Peter Eliyahu Kornfeld
              Reporter:
              markn Mark Nelson
              Peer reviewer:
              Mark Nelson
              Integrator:
              Adrian Greeve
              Tester:
              Elizabeth Dalton
              Participants:
              Component watchers:
              Amaia Anabitarte, Carlos Escobedo, Ferran Recio, Ilya Tregubov, Sara Arjona (@sarjona)
              Votes:
              2 Vote for this issue
              Watchers:
              6 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Fix Release Date:
                11/Mar/19