[MDL-60459] Not including 'visibleoncoursepage' in module info causes error in update_moduleinfo - Moodle Tracker

XML

Word

Printable

Affected Branches:
MOODLE_33_STABLE, MOODLE_37_STABLE
Fixed Branches:
MOODLE_35_STABLE, MOODLE_36_STABLE
Pull from Repository:
git://github.com/markn86/moodle.git
Pull Master Branch:
~~MDL-60459~~_master
Pull Master Diff URL:
https://github.com/markn86/moodle/compare/master...MDL-60459_master
Testing Instructions:
Hide

Test 1 - Regression test.

Edit the file lib/testing/generator/module_generator.php and in prepare_moduleinfo_record and remove the line 'visibleoncoursepage' => 1.

Run the unit tests in mod/book/tests/lib_test.php.

Confirm there are no errors.

Test 2

Edit the file course/modlib.php and add unset($moduleinfo->visibleoncoursepage) to the start of the function update_moduleinfo.

Visit a course.

Add a book.

Edit the book.

Save changes.

Confirm there are no errors.
Show
Test 1 - Regression test. Edit the file lib/testing/generator/module_generator.php and in prepare_moduleinfo_record and remove the line 'visibleoncoursepage' => 1 . Run the unit tests in mod/book/tests/lib_test.php . Confirm there are no errors. Test 2 Edit the file course/modlib.php and add unset($moduleinfo->visibleoncoursepage) to the start of the function update_moduleinfo . Visit a course. Add a book. Edit the book. Save changes. Confirm there are no errors.

Similar to ~~MDL-59655~~ but is a bug in the update_moduleinfo function.

has been marked as being related by

MDL-59655 Not including 'visibleoncoursepage' in module info causes error in add_moduleinfo

Participants:: Adrian Greeve, CiBoT, Eddie Crosbie, Elizabeth Dalton, Eloy Lafuente (stronk7), Marina Glancy, Mark Nelson, Nadav Kavalerchik, Peter Eliyahu Kornfeld

Component watchers:: Amaia Anabitarte, Carlos Escobedo, Ferran Recio, Ilya Tregubov, Sara Arjona (@sarjona)