Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-60474

Grading interface student switch user tool not reflecting sort order of grading table

    XMLWordPrintable

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 3.2.4, 3.4.5
    • Fix Version/s: 3.7
    • Component/s: Assignment
    • Testing Instructions:
      Hide

      Requires testing in LTR language and RTL language.

      Requires testing in Boost theme and Clean themes.

      Setup:

      1. Create a course with 10 students and a teacher

      2. Create an assignment with blind marking OFF, marking workflow OFF, marker allocation OFF and online text ON

      3. Create an assignment with blind marking ON, marking workflow OFF, marker allocation OFF and online text ON

      4. Create an assignment with blind marking OFF, marking workflow ON, marker allocation OFF and online text ON

      5. Create an assignment with blind marking OFF, marking workflow ON, marker allocation ON and online text ON

      6. As the first student, create a submission for each assignment.

      7. As the teacher for every assignment, grade the student submission giving them a grade of 50.

      8. As the teacher for the 2 assignments with marking workflow enabled, set the marking workflow state for the student submission to "Marking completed".

      Verify each filter type:

      For each assignment go to the table with all the submissions listed (View all submissions).

      Change the "Filter" option beneath the table to each of the possible values (No filter, Not submitted, Submitted, Requires grading, Granted extension).

      If the current assignment has marking workflow or allocated markers enabled, repeat these tests using one of the additional filters on the grading table for "Marker filter" or "Workflow filter".

      Repeat for for each filter type:

      1. Once grading table has shown the list of submissions with the current filter applied, click on the "Grade" button for the first submission in the list.

      2. Verify in the "Grading page" for the submission - the count now reflect the currently applied filter (1 of 10 means the first user on the previous table of 10 submissions).

      3. Verify that clicking on the Filter icon shows the correct filter is now being applied to the list of users. Verify that clicking on a different filter in this list changes the list of users displayed immediately.

      4. Verify that after changing the filter this way and returning to the grading table, the grading table applies the new filter.

      5. Return to the grading table and sort the list of submissions by the user Email.

      6. Click on the "Grade" button for the first user in the new list and verify that the list of users  in the user select field on the "Grading page" for the submission reflects the new sort order. 

      7. Return to the grading table and sort the list of submissions by the "Status" column.

      8. Click on the "Grade" button for the first user in the new list and verify that the list of users  in the user select field on the "Grading page" for the submission reflects the new sort order. 

      9. Return to the grading table and apply a filter so that no users show in the grading table (Granted extension is a good choice).

      10. Return to the front page of the assignment and click the "Grade" button there.

      11. Verify that no users are listed, but any active filters can be seen (and changed) by clicked on the "Filter" icon beneath the user selector. 

      Show
      Requires testing in LTR language and RTL language. Requires testing in Boost theme and Clean themes. Setup: 1. Create a course with 10 students and a teacher 2. Create an assignment with blind marking OFF, marking workflow OFF, marker allocation OFF and online text ON 3. Create an assignment with blind marking ON, marking workflow OFF, marker allocation OFF and online text ON 4. Create an assignment with blind marking OFF, marking workflow ON, marker allocation OFF and online text ON 5. Create an assignment with blind marking OFF, marking workflow ON, marker allocation ON and online text ON 6. As the first student, create a submission for each assignment. 7. As the teacher for every assignment, grade the student submission giving them a grade of 50. 8. As the teacher for the 2 assignments with marking workflow enabled, set the marking workflow state for the student submission to "Marking completed". Verify each filter type: For each assignment go to the table with all the submissions listed (View all submissions). Change the "Filter" option beneath the table to each of the possible values (No filter, Not submitted, Submitted, Requires grading, Granted extension). If the current assignment has marking workflow or allocated markers enabled, repeat these tests using one of the additional filters on the grading table for "Marker filter" or "Workflow filter". Repeat for for each filter type: 1. Once grading table has shown the list of submissions with the current filter applied, click on the "Grade" button for the first submission in the list. 2. Verify in the "Grading page" for the submission - the count now reflect the currently applied filter (1 of 10 means the first user on the previous table of 10 submissions). 3. Verify that clicking on the Filter icon shows the correct filter is now being applied to the list of users. Verify that clicking on a different filter in this list changes the list of users displayed immediately. 4. Verify that after changing the filter this way and returning to the grading table, the grading table applies the new filter. 5. Return to the grading table and sort the list of submissions by the user Email. 6. Click on the "Grade" button for the first user in the new list and verify that the list of users  in the user select field on the "Grading page" for the submission reflects the new sort order.  7. Return to the grading table and sort the list of submissions by the "Status" column. 8. Click on the "Grade" button for the first user in the new list and verify that the list of users  in the user select field on the "Grading page" for the submission reflects the new sort order.  9. Return to the grading table and apply a filter so that no users show in the grading table (Granted extension is a good choice). 10. Return to the front page of the assignment and click the "Grade" button there. 11. Verify that no users are listed, but any active filters can be seen (and changed) by clicked on the "Filter" icon beneath the user selector. 
    • Affected Branches:
      MOODLE_32_STABLE, MOODLE_34_STABLE
    • Fixed Branches:
      MOODLE_37_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-60474-master

      Description

      Teacher clicks on assignment - View all submissions
      Filters for groups and sorts the name column by First name
      Clicks the Grade button to bring up the grading interface
      Grades the first student, uses the student selection tool top right to move to the next student only it is not the expected student.

      e.g. Grading table order: Abbie Wordsworth, Ben Smith, Carole Jones (sorted by first name). In the grading interface when the teacher clicks the next arrow on the student selection tool, they expect to see the students appear in the above order, however they are actually in order by last name. After Abbie Wordsworth the teacher would expect Ben Smith to be next, but Carole Jones appears next instead (names are fictional).

      The student selection tool is sorted by last name and ignores the order the students are in on the grading table. I have looked and can't see how to change this. I would expect the student selector in the grading interface to reflect the sort order of the grading table.

        Attachments

        1. 9.PNG
          9.PNG
          228 kB
        2. 8.PNG
          8.PNG
          259 kB
        3. 7.PNG
          7.PNG
          130 kB
        4. 6.PNG
          6.PNG
          171 kB
        5. 5.PNG
          5.PNG
          181 kB
        6. 4.PNG
          4.PNG
          100 kB
        7. 3.PNG
          3.PNG
          190 kB
        8. 27.PNG
          27.PNG
          165 kB
        9. 26.PNG
          26.PNG
          98 kB
        10. 25.PNG
          25.PNG
          100 kB
        11. 24.PNG
          24.PNG
          122 kB
        12. 23.PNG
          23.PNG
          46 kB
        13. 22.PNG
          22.PNG
          120 kB
        14. 21.PNG
          21.PNG
          147 kB
        15. 20.PNG
          20.PNG
          151 kB
        16. 2.PNG
          2.PNG
          139 kB
        17. 19.PNG
          19.PNG
          101 kB
        18. 18.PNG
          18.PNG
          104 kB
        19. 17.PNG
          17.PNG
          48 kB
        20. 17.PNG
          17.PNG
          115 kB
        21. 16.PNG
          16.PNG
          143 kB
        22. 15.PNG
          15.PNG
          153 kB
        23. 14.PNG
          14.PNG
          173 kB
        24. 13.PNG
          13.PNG
          195 kB
        25. 12.PNG
          12.PNG
          118 kB
        26. 11.PNG
          11.PNG
          103 kB
        27. 10.PNG
          10.PNG
          184 kB
        28. 1.PNG
          1.PNG
          157 kB

          Issue Links

            Activity

              People

              Assignee:
              damyon Damyon Wiese
              Reporter:
              rutha Ruth Andrews
              Peer reviewer:
              Simey Lameze
              Integrator:
              Jun Pataleta
              Tester:
              Janelle Barcega
              Participants:
              Component watchers:
              Adrian Greeve, Jake Dallimore, Mathew May, Mihail Geshoski, Peter Dias
              Votes:
              15 Vote for this issue
              Watchers:
              14 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Fix Release Date:
                20/May/19

                  Time Tracking

                  Estimated:
                  Original Estimate - 0 minutes
                  0m
                  Remaining:
                  Remaining Estimate - 0 minutes
                  0m
                  Logged:
                  Time Spent - 4 hours
                  4h