Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-60478

Only display checknet alert once

XMLWordPrintable

    • Icon: Improvement Improvement
    • Resolution: Fixed
    • Icon: Major Major
    • 3.5
    • 3.3.2, 3.4
    • SCORM
    • MOODLE_33_STABLE, MOODLE_34_STABLE
    • MOODLE_35_STABLE
    • wip-MDL-60478-m35
    • Hide

      Manual Testing

      1. Create a course.
      2. Navigate into the course, turn editing on, and add a SCORM activity, using the attached SCO package: prodding-sco.zip.
      3. Save and display the SCORM activity.
      4. Simulate being unable to connect to the site:
        • If you're using Chrome:
          1. Right-click on the page and click "Inspect" to open the Developer Tools.
          2. Click on the "Network" tab.
          3. Tick the "Offline" checkbox.
        • If you're not using Chrome, open your file browser and navigate to /path/to/moodle/lib/yui/build/assets and rename checknet.txt to _checknet.txt
      5. Wait at least 30 seconds.
        • Confirm that an alert is displayed.
      6. Close the alert.
      7. Wait another minute or two.
        • Confirm that no more alerts are being displayed. 
      Show
      Manual Testing Create a course. Navigate into the course, turn editing on, and add a SCORM activity, using the attached SCO package: prodding-sco.zip . Save and display the SCORM activity. Simulate being unable to connect to the site: If you're using Chrome: Right-click on the page and click " Inspect " to open the Developer Tools. Click on the " Network " tab. Tick the " Offline " checkbox. If you're not using Chrome, open your file browser and navigate to /path/to/moodle/lib/yui/build/assets and rename checknet.txt to _checknet.txt Wait at least 30 seconds. Confirm that an alert is displayed. Close the alert. Wait another minute or two. Confirm that no more alerts are being displayed. 

      As discussed in MDL-57804, change checknet for SCORM to only display the alert one time. Also, possibly, increase timeout and duration between checks as described by Mathew Gancarz

      The latter change would involve abstracting the checknet mod to accept some additional arguments. 

        1. MDL60478.PNG
          316 kB
          Janelle Barcega

            agroshek Amy Groshek
            agroshek Amy Groshek
            Matteo Scaramuccia Matteo Scaramuccia
            Jun Pataleta Jun Pataleta
            Janelle Barcega Janelle Barcega
            Votes:
            5 Vote for this issue
            Watchers:
            7 Start watching this issue

              Created:
              Updated:
              Resolved:

                Error rendering 'clockify-timesheets-time-tracking-reports:timer-sidebar'. Please contact your Jira administrators.