Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-60481

unoconv file conversions should timeout on failures

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Duplicate
    • Icon: Minor Minor
    • None
    • 3.1.6, 3.1.7, 3.1.8, 3.2.3, 3.2.4
    • Assignment
    • MOODLE_31_STABLE, MOODLE_32_STABLE
    • wip-MDL-60481-master
    • Hide
      • create a new site using the wip branch;
      • follow the steps here https://docs.moodle.org/31/en/Installing_unoconv to enable unoconv on the site;
      • validate that unoconv is installed and working;
      • validate under site administration, plugins, Document converters, Unoconv, there is an option for Enable unoconv timeout;
      • validate that the default value for the option is none;
      • change the value and confirm that it saves;
      • change the value to 120 and save the changes;
      • under site administration, plugins, Document converters, ensure that Unoconv is enabled;
      • ensure that $CFG->pathtounoconv is set in config.php;
      • unit tests fileconverter_unoconv_converter_testcase files/converter/unoconv/converter_test.php
      Show
      create a new site using the wip branch; follow the steps here https://docs.moodle.org/31/en/Installing_unoconv to enable unoconv on the site; validate that unoconv is installed and working; validate under site administration, plugins, Document converters, Unoconv, there is an option for Enable unoconv timeout; validate that the default value for the option is none; change the value and confirm that it saves; change the value to 120 and save the changes; under site administration, plugins, Document converters, ensure that Unoconv is enabled; ensure that $CFG->pathtounoconv is set in config.php; unit tests fileconverter_unoconv_converter_testcase files/converter/unoconv/converter_test.php

      Submitting an Excel file into an assignment that contains data beyond row 65,536 will cause a unoconv document conversion to hang up until it is killed manually when viewed within Moodle's grading interface, with the nasty side effect of locking the teacher's moodle session until that manual kill occurs.

      We suspect that the same issue exists when the Excel file is converted by the cron as well. We routinely find and fix these hung cron issues by clearing the submission out of mdl_assignfeedback_editpdf_queue, killing the cron, and killing all soffice.bin processes.

      This could potentially be resolved if Moodle were to somehow check the row count on the excel file and if it exceeds the row limit of 65,536, not pass the file along to unoconv, while providing a relevant error message to the instructor instead explaining why it can't be converted.

      To replicate this issue:

      1. Create an Excel file with data beyond row 65,536. Row 1,048,576 to be more specific, as this is the row we've seen this occur with so far, but theoretically it should be any row beyond 65,536.
      2. Submit the Excel file to an assignment.
      3. Attempt to grade the assignment within the grader interface.
      4. Wait awhile.
      5. Search for and kill the hung unoconv process.

            Unassigned Unassigned
            jessestilwell Jesse Stilwell
            Tim Hunt Tim Hunt
            Votes:
            10 Vote for this issue
            Watchers:
            11 Start watching this issue

              Created:
              Updated:
              Resolved:

                Estimated:
                Original Estimate - Not Specified
                Not Specified
                Remaining:
                Remaining Estimate - 0 minutes
                0m
                Logged:
                Time Spent - 1 hour
                1h

                  Error rendering 'clockify-timesheets-time-tracking-reports:timer-sidebar'. Please contact your Jira administrators.